Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2092853002: Pass needed value to CXFA_Node constructor (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Pass needed value to CXFA_Node constructor Currently the CXFA_Node constructor will call out to lookup the object type for a given element type. There is only one called of this constructor and it already has the object type so just pass it through instead of getting the element data a second time. Committed: https://pdfium.googlesource.com/pdfium/+/b97784706ec898ff6b1c36f1564c0c66f9419b17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M xfa/fxfa/parser/xfa_document_imp.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-23 19:34:22 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-23 20:32:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092853002/1
4 years, 6 months ago (2016-06-23 20:33:58 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 20:34:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/b97784706ec898ff6b1c36f1564c0c66f941...

Powered by Google App Engine
This is Rietveld 408576698