cc/ipc/compositor_frame.typemap - Issue 2092843002: Implement CompositorFrame Struct Traits

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/ipc/compositor_frame.typemap

Issue 2092843002: Implement CompositorFrame Struct Traits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Delete code Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 mojom = "//cc/ipc/compositor_frame.mojom"

	6 public_headers = [ "//cc/output/compositor_frame.h" ]

	7 traits_headers = [ "//cc/ipc/compositor_frame_struct_traits.h" ]

	8 public_deps = [

	9 "//cc",

	10 ]

	11 type_mappings = [ "cc.mojom.CompositorFrame=std::unique_ptr<cc::CompositorFrame> [pass_by_value]" ]
	rjkroege 2016/06/23 19:13:55 This pass by value thing is new. What does it do? This pass by value thing is new. What does it do? Fady Samuel 2016/06/25 04:31:12 Normally mojo will pass things around by const ref Show quoted text On 2016/06/23 19:13:55, rjkroege wrote: > This pass by value thing is new. What does it do? Normally mojo will pass things around by const reference, but you don't want to pass around unique_ptrs by reference you want them to be uniquely owned and thus passed by value.
OLD	NEW