Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2092773002: headless: Allow per-context protocol handlers (Closed)

Created:
4 years, 6 months ago by Sami
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Allow per-context protocol handlers Make it possible to set protocol handlers per browser context instead of having to replace handlers for the browser globally. BUG=546953 Committed: https://crrev.com/d34af147d3ca3e62e86cfa566d4233589b1e6cd1 Cr-Commit-Position: refs/heads/master@{#401638}

Patch Set 1 #

Patch Set 2 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -440 lines) Patch
M headless/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_context_impl.h View 2 chunks +5 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_browser_context_impl.cc View 3 chunks +15 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_browser_main_parts.cc View 1 chunk +2 lines, -1 line 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.h View 1 chunk +1 line, -0 lines 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 2 chunks +1 line, -212 lines 0 comments Download
A + headless/lib/headless_browser_context_browsertest.cc View 3 chunks +47 lines, -215 lines 0 comments Download
M headless/public/headless_browser.h View 2 chunks +0 lines, -5 lines 0 comments Download
M headless/public/headless_browser_context.h View 1 3 chunks +9 lines, -1 line 0 comments Download
A headless/test/test_protocol_handler.h View 1 chunk +29 lines, -0 lines 0 comments Download
A headless/test/test_protocol_handler.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A headless/test/test_url_request_job.h View 1 chunk +38 lines, -0 lines 0 comments Download
A headless/test/test_url_request_job.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
4 years, 6 months ago (2016-06-23 16:04:34 UTC) #3
alex clarke (OOO till 29th)
lgtm
4 years, 6 months ago (2016-06-23 16:14:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092773002/20001
4 years, 6 months ago (2016-06-23 16:19:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 17:20:07 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 17:41:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d34af147d3ca3e62e86cfa566d4233589b1e6cd1
Cr-Commit-Position: refs/heads/master@{#401638}

Powered by Google App Engine
This is Rietveld 408576698