Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3301)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_subpage.js

Issue 2092763004: [MD Settings] Implement search in material design passwords. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback and Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page/settings_subpage.js
diff --git a/chrome/browser/resources/settings/settings_page/settings_subpage.js b/chrome/browser/resources/settings/settings_page/settings_subpage.js
index 397e89addb82ae525d02da1d5539b4da745a95d3..4b584fcd642b67e6065aaa442fbc13d61a1d514d 100644
--- a/chrome/browser/resources/settings/settings_page/settings_subpage.js
+++ b/chrome/browser/resources/settings/settings_page/settings_subpage.js
@@ -20,6 +20,15 @@ Polymer({
properties: {
pageTitle: String,
+
+ /** Setting a |searchLabel| will enable search. */
+ searchLabel: String,
+
+ searchTerm: {
+ type: String,
+ notify: true,
+ value: '',
+ },
},
/** @private */
@@ -27,4 +36,10 @@ Polymer({
// Event is caught by settings-animated-pages.
this.fire('subpage-back');
},
+
+ /** @private */
+ onSearchChanged_: function(e) {
+ this.searchTerm = e.detail;
+ this.notifyPath('searchTerm', this.searchTerm);
dpapad 2016/07/20 19:34:51 Is the call to notifyPath necessary? Given that we
hcarmona 2016/07/20 21:06:07 Not necessary. Removed.
+ },
});

Powered by Google App Engine
This is Rietveld 408576698