Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2246)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_subpage.html

Issue 2092763004: [MD Settings] Implement search in material design passwords. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update to better match mocks Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page/settings_subpage.html
diff --git a/chrome/browser/resources/settings/settings_page/settings_subpage.html b/chrome/browser/resources/settings/settings_page/settings_subpage.html
index fa94d0769b665fd71012bd192229ae40c2f70b1c..7d1bfdae62ff0e690145388aa5e2f036d99e76dc 100644
--- a/chrome/browser/resources/settings/settings_page/settings_subpage.html
+++ b/chrome/browser/resources/settings/settings_page/settings_subpage.html
@@ -2,6 +2,7 @@
<link rel="import" href="chrome://resources/polymer/v1_0/iron-resizable-behavior/iron-resizable-behavior.html">
<link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable-behavior.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input.html">
<link rel="import" href="/icons.html">
<link rel="import" href="/settings_shared_css.html">
@@ -29,11 +30,55 @@
color: var(--settings-nav-grey);
font-size: 107.6923%; /* go to 14px from 13px */
}
+
+ paper-input-container {
+ -webkit-margin-start: auto;
+ width: var(--paper-input-max-width);
+ }
+
+ input[type='search']::-webkit-search-cancel-button {
+ -webkit-appearance: none;
+ }
+
+ #prompt,
+ #searchInput {
+ color: var(--google-grey-500);
+ font-size: 13px;
+ line-height: 36px;
+ }
+
+ #clearSearch {
+ -webkit-margin-end: -8px;
+ -webkit-margin-start: 8px;
+ }
+
+ :root {
+ --paper-icon-button {
+ height: 36px;
+ width: 36px;
+ }
+
+ --paper-input-suffix: {
+ /* Required to align the icon in |clearSearch| vertically. */
+ line-height: 0;
+ }
+ }
</style>
<div class="settings-box first">
<paper-icon-button icon="settings:arrow-back" on-tap="onTapBack_">
</paper-icon-button>
<h2>[[pageTitle]]</h2>
+ <paper-input-container id="searchContainer" no-label-float hidden
dpapad 2016/07/13 18:11:17 Can we re-use the existing cr-search-field instead
hcarmona 2016/07/13 23:19:40 cr-search-field doesn't match the mocks. If we can
dpapad 2016/07/13 23:32:41 cr-search-field logic is broken down to two parts
hcarmona 2016/07/20 18:59:47 Sounds good.
+ on-search="onSearchTermSearch_">
+ <label id="prompt">[[searchLabel]]</label>
+ <input is="iron-input" id="searchInput" type="search"
+ aria-labelledby="prompt" incremental>
+ </input>
+ <paper-icon-button suffix icon="cr:cancel" id="clearSearch"
+ on-tap="onTapClear_" title="[[clearLabel]]"
+ hidden$="[[!hasSearchTerm_(searchTerm)]]">
+ </paper-icon-button>
+ </paper-input-container>
</div>
<content></content>
</template>

Powered by Google App Engine
This is Rietveld 408576698