[MD Settings] Implement search in material design passwords.

chrome/browser/resources/settings/settings_page/settings_subpage_search.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-subpage' shows a subpage beneath a subheader. The header contains
  * the subpage title and a back icon. The back icon fires an event which
  * is caught by settings-animated-pages, so it requires no separate handling.
  */
 
 Polymer({
-  is: 'settings-subpage',
+  is: 'settings-subpage-search',
 
-  behaviors: [
-    // TODO(michaelpg): phase out NeonAnimatableBehavior.
-    Polymer.NeonAnimatableBehavior,
-    Polymer.IronResizableBehavior,
-  ],
+  behaviors: [CrSearchFieldBehavior],
 
-  properties: {
-    pageTitle: String,
+  /** @private */
+  onTapClear_: function() {
+    this.$.searchInput.value = '';

[dpapad, 2016/07/20 19:34:51]

Can we avoid having to fire any events manually by calling
CrSearchFieldBehavior#setValue() instead? IIUC this method is supposed to be the
canonical way of programmatically modifying the textbox contents.

https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_search...

[hcarmona, 2016/07/20 21:06:07]

Done.

+
+    // Fire events to update the UI. These are fired when the user changes the
+    // input, but not when value is set.
+    this.$.searchInput.fire('input');
+    this.$.searchInput.fire('search');
   },
 
-  /** @private */
-  onTapBack_: function() {
-    // Event is caught by settings-animated-pages.
-    this.fire('subpage-back');
+  /**
+   * @param {string} lastValue_

[dpapad, 2016/07/20 19:34:51]

Nit: Parameter names don't usually have underscore suffix.

[hcarmona, 2016/07/20 21:06:07]

On second look, this entire method is unnecessary, bound directly to
|lastValue_|.

+   * @return {boolean}
+   */
+  hasSearchTerm_: function(lastValue_) {
+    return !!lastValue_;
   },
 });