Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 /** | 5 /** |
| 6 * @fileoverview | 6 * @fileoverview |
| 7 * 'settings-subpage' shows a subpage beneath a subheader. The header contains | 7 * 'settings-subpage' shows a subpage beneath a subheader. The header contains |
| 8 * the subpage title and a back icon. The back icon fires an event which | 8 * the subpage title and a back icon. The back icon fires an event which |
| 9 * is caught by settings-animated-pages, so it requires no separate handling. | 9 * is caught by settings-animated-pages, so it requires no separate handling. |
| 10 */ | 10 */ |
| 11 | 11 |
| 12 Polymer({ | 12 Polymer({ |
| 13 is: 'settings-subpage', | 13 is: 'settings-subpage', |
| 14 | 14 |
| 15 behaviors: [ | 15 behaviors: [ |
| 16 // TODO(michaelpg): phase out NeonAnimatableBehavior. | 16 // TODO(michaelpg): phase out NeonAnimatableBehavior. |
| 17 Polymer.NeonAnimatableBehavior, | 17 Polymer.NeonAnimatableBehavior, |
| 18 Polymer.IronResizableBehavior, | 18 Polymer.IronResizableBehavior, |
| 19 ], | 19 ], |
| 20 | 20 |
| 21 properties: { | 21 properties: { |
| 22 pageTitle: String, | 22 pageTitle: String, |
| 23 | |
| 24 /** Setting a |searchLabel| will enable search. */ | |
| 25 searchLabel: String, | |
| 26 | |
| 27 searchTerm: { | |
| 28 type: String, | |
| 29 notify: true, | |
| 30 value: '', | |
| 31 }, | |
| 23 }, | 32 }, |
| 24 | 33 |
| 25 /** @private */ | 34 /** @private */ |
| 26 onTapBack_: function() { | 35 onTapBack_: function() { |
| 27 // Event is caught by settings-animated-pages. | 36 // Event is caught by settings-animated-pages. |
| 28 this.fire('subpage-back'); | 37 this.fire('subpage-back'); |
| 29 }, | 38 }, |
| 39 | |
| 40 /** @private */ | |
| 41 onSearchChanged_: function(e) { | |
| 42 this.searchTerm = e.detail; | |
| 43 this.notifyPath('searchTerm', this.searchTerm); | |
|
dpapad
2016/07/20 19:34:51
Is the call to notifyPath necessary?
Given that we
hcarmona
2016/07/20 21:06:07
Not necessary. Removed.
| |
| 44 }, | |
| 30 }); | 45 }); |
| OLD | NEW |