Limit the number of extra/missing files that get printed.

Limit the number of extra/missing files that get printed.

The message now look like this:

2 files missing from the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex.h
22 extra files in the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert_.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex_.h
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\string\wmemmove_s.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\asctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\clock.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\days.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\difftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\gmtime.cpp
        ...

R=thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/a0e66ea609733eddfd02098ee50eda4cc13a1775

[Sébastien Marchand, 2016-06-23 15:50:24]

Description was changed from

==========
Limit the number of extra/missing files that get printed.

R=thakis@chromium.org
==========

to

==========
Limit the number of extra/missing files that get printed.

The message now look like this:

2 files are missing from the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex.h
There's 22 extra files in the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert_.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex_.h
       
vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\string\wmemmove_s.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\asctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\clock.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\days.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\difftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\gmtime.cpp
        ...

R=thakis@chromium.org
==========

[Sébastien Marchand, 2016-06-23 15:50:33]

PTAL.

[Nico, 2016-06-23 15:53:45]

lgtm, thanks!

nits below are very optional.

https://codereview.chromium.org/2092753003/diff/1/win_toolchain/get_toolchain...
File win_toolchain/get_toolchain_if_necessary.py (right):

https://codereview.chromium.org/2092753003/diff/1/win_toolchain/get_toolchain...
win_toolchain/get_toolchain_if_necessary.py:144: (len(missing_files), 's are' if
len(missing_files) > 1 else '',
nit: i'd just say "%d files missing", it's not like this is user-facing ui

https://codereview.chromium.org/2092753003/diff/1/win_toolchain/get_toolchain...
win_toolchain/get_toolchain_if_necessary.py:152: print ('There\'s %d extra
file%s in the %s version of the toolchain:' %
same nit: drop "There's", and i'd always just say "files"

[Sébastien Marchand, 2016-06-23 15:56:59]

Description was changed from

==========
Limit the number of extra/missing files that get printed.

The message now look like this:

2 files are missing from the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex.h
There's 22 extra files in the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert_.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex_.h
       
vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\string\wmemmove_s.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\asctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\clock.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\days.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\difftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\gmtime.cpp
        ...

R=thakis@chromium.org
==========

to

==========
Limit the number of extra/missing files that get printed.

The message now look like this:

2 files missing from the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex.h
22 extra files in the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert_.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex_.h
       
vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\string\wmemmove_s.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\asctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\clock.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\days.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\difftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\gmtime.cpp
        ...

R=thakis@chromium.org
==========

[Sébastien Marchand, 2016-06-23 15:57:51]

Thanks for the quick review !

https://codereview.chromium.org/2092753003/diff/1/win_toolchain/get_toolchain...
File win_toolchain/get_toolchain_if_necessary.py (right):

https://codereview.chromium.org/2092753003/diff/1/win_toolchain/get_toolchain...
win_toolchain/get_toolchain_if_necessary.py:144: (len(missing_files), 's are' if
len(missing_files) > 1 else '',
On 2016/06/23 15:53:45, Nico wrote:
> nit: i'd just say "%d files missing", it's not like this is user-facing ui

Done.

https://codereview.chromium.org/2092753003/diff/1/win_toolchain/get_toolchain...
win_toolchain/get_toolchain_if_necessary.py:152: print ('There\'s %d extra
file%s in the %s version of the toolchain:' %
On 2016/06/23 15:53:44, Nico wrote:
> same nit: drop "There's", and i'd always just say "files"

Done.

[Sébastien Marchand, 2016-06-23 16:02:13]

small update, it's probably more 'Pythonic' like this ?

[Nico, 2016-06-23 16:04:46]

Yes, that's a bit nicer. (still lgtm)

[Sébastien Marchand, 2016-06-23 16:05:03]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-06-23 16:05:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2092753003/40001

[commit-bot: I haz the power, 2016-06-23 16:11:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 16:11:31]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[Sébastien Marchand, 2016-06-23 16:12:25]

sebmarchand@chromium.org changed reviewers:
+ scottmg@chromium.org

[Sébastien Marchand, 2016-06-23 16:12:26]

+scottmg@ for ownership approval.

[scottmg, 2016-06-23 16:45:24]

lgtm either way

https://codereview.chromium.org/2092753003/diff/40001/win_toolchain/get_toolc...
File win_toolchain/get_toolchain_if_necessary.py (right):

https://codereview.chromium.org/2092753003/diff/40001/win_toolchain/get_toolc...
win_toolchain/get_toolchain_if_necessary.py:142: if len(missing_files):
These two duplicated blocks almost look like they could be a function? But I
guess the strings make it borderline.

[Sébastien Marchand, 2016-06-23 17:41:45]

https://codereview.chromium.org/2092753003/diff/40001/win_toolchain/get_toolc...
File win_toolchain/get_toolchain_if_necessary.py (right):

https://codereview.chromium.org/2092753003/diff/40001/win_toolchain/get_toolc...
win_toolchain/get_toolchain_if_necessary.py:142: if len(missing_files):
On 2016/06/23 16:45:24, scottmg wrote:
> These two duplicated blocks almost look like they could be a function? But I
> guess the strings make it borderline.

Yeah, I thought about this but it seemed a little bit overkill, not sure it's
worth it.

[Sébastien Marchand, 2016-06-23 17:43:55]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-06-23 17:44:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2092753003/40001

[commit-bot: I haz the power, 2016-06-23 17:47:17]

Description was changed from

==========
Limit the number of extra/missing files that get printed.

The message now look like this:

2 files missing from the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex.h
22 extra files in the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert_.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex_.h
       
vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\string\wmemmove_s.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\asctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\clock.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\days.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\difftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\gmtime.cpp
        ...

R=thakis@chromium.org
==========

to

==========
Limit the number of extra/missing files that get printed.

The message now look like this:

2 files missing from the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex.h
22 extra files in the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert_.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex_.h
       
vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\string\wmemmove_s.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\asctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\clock.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\days.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\difftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\gmtime.cpp
        ...

R=thakis@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/a0e66ea609733e...
==========

[commit-bot: I haz the power, 2016-06-23 17:47:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/a0e66ea609733e...