Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 2092743002: Revert of Make ChromeVox Next a setting in options page. (Closed)

Created:
4 years, 6 months ago by flackr
Modified:
4 years, 6 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make ChromeVox Next a setting in options page. (patchset #11 id:200001 of https://codereview.chromium.org/2079073002/ ) Reason for revert: Failing BackgroundTest.DisappearingObject on chromiumos: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/21657 I verified locally that it seems to consistently time out with this patch. Original issue's description: > Make ChromeVox Next a setting in options page. > > - persists the ChromeVox mode in local storage; this makes it so that you can start using ChromeVox Next right way on startup > - makes the new ChromeVox experience a checkbox in options; rework some of the mode setting logic to make this happen. > - add strings for announcing switches between the new and classic experiences; also, fire a message center notification if switching to the new experience for the first time. > > This change required some non-trivial amount of refactoring: > - use ChromeVoxState.instance.getCurrentRange() as the definitive notion of mode; mode is based on current range. > - ChromeVoxState and global were both "global" objects; merge them into ChromeVoxState > - removed and simplified various mode related logic > - Background (the ChromeVox Next background page) now explicitly depends on ChromeVoxBackground (ChromeVox classic background page) via goog.require. This was necessary to ensure that the window.prefs object was created already for keyboard map switching on startup > > BUG=618094, 618092, 618090 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/e771bbe3e029830c01fb85d50a9be5559dc7aac4 > Cr-Commit-Position: refs/heads/master@{#401596} TBR=dmazzoni@chromium.org,dtseng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618094, 618092, 618090 Committed: https://crrev.com/61426ca69aa0e2e295c34016ff571a0a864ecadf Cr-Commit-Position: refs/heads/master@{#401600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -322 lines) Patch
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js View 1 chunk +23 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/command_store.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 27 chunks +151 lines, -157 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 12 chunks +45 lines, -50 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/chromevox_state.js View 2 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 7 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/tabs_automation_handler.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/braille_background.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd View 1 chunk +1 line, -13 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
flackr
Created Revert of Make ChromeVox Next a setting in options page.
4 years, 6 months ago (2016-06-23 14:28:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092743002/1
4 years, 6 months ago (2016-06-23 14:28:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 14:29:57 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 14:31:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61426ca69aa0e2e295c34016ff571a0a864ecadf
Cr-Commit-Position: refs/heads/master@{#401600}

Powered by Google App Engine
This is Rietveld 408576698