Chromium Code Reviews
DescriptionRevert of Make ChromeVox Next a setting in options page. (patchset #11 id:200001 of https://codereview.chromium.org/2079073002/ )
Reason for revert:
Failing BackgroundTest.DisappearingObject on chromiumos:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/21657
I verified locally that it seems to consistently time out with this patch.
Original issue's description:
> Make ChromeVox Next a setting in options page.
>
> - persists the ChromeVox mode in local storage; this makes it so that you can start using ChromeVox Next right way on startup
> - makes the new ChromeVox experience a checkbox in options; rework some of the mode setting logic to make this happen.
> - add strings for announcing switches between the new and classic experiences; also, fire a message center notification if switching to the new experience for the first time.
>
> This change required some non-trivial amount of refactoring:
> - use ChromeVoxState.instance.getCurrentRange() as the definitive notion of mode; mode is based on current range.
> - ChromeVoxState and global were both "global" objects; merge them into ChromeVoxState
> - removed and simplified various mode related logic
> - Background (the ChromeVox Next background page) now explicitly depends on ChromeVoxBackground (ChromeVox classic background page) via goog.require. This was necessary to ensure that the window.prefs object was created already for keyboard map switching on startup
>
> BUG=618094, 618092, 618090
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/e771bbe3e029830c01fb85d50a9be5559dc7aac4
> Cr-Commit-Position: refs/heads/master@{#401596}
TBR=dmazzoni@chromium.org,dtseng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=618094, 618092, 618090
Committed: https://crrev.com/61426ca69aa0e2e295c34016ff571a0a864ecadf
Cr-Commit-Position: refs/heads/master@{#401600}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|