Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2092703002:
Support Custom Elements v1 in attachShadow (Closed)
|
Created:
4 years, 6 months ago by hayato Modified:
4 years, 6 months ago CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSupport Custom Elements v1 in attachShadow
After renaming CustomElement to CustomElementV0, it looks the support of Custom
Elements v1 in attachShadow has been forgotten. Fix it.
BUG=531990, 621942
Committed: https://crrev.com/fa38a0afc1d55a8a625b87514d4799877c2d2ef7
Cr-Commit-Position: refs/heads/master@{#401779}
Patch Set 1 #
Messages
Total messages: 21 (12 generated)
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092703002/1
Description was changed from ========== Allow Custom Element v1 to call attachShadow BUG= ========== to ========== Allow Custom Element v1 to call attachShadow It looks we forgot to support Custom Elements in attachShadow when renaming CustomElement to CustomElementV0. BUG=531990,621942 ==========
Description was changed from ========== Allow Custom Element v1 to call attachShadow It looks we forgot to support Custom Elements in attachShadow when renaming CustomElement to CustomElementV0. BUG=531990,621942 ========== to ========== Allow Custom Element v1 to call attachShadow It looks we forgot to support Custom Elements v1 in attachShadow when renaming CustomElement to CustomElementV0. BUG=531990,621942 ==========
Description was changed from ========== Allow Custom Element v1 to call attachShadow It looks we forgot to support Custom Elements v1 in attachShadow when renaming CustomElement to CustomElementV0. BUG=531990,621942 ========== to ========== Allow Custom Element v1 to call attachShadow It looks no once has not supported Custom Elements v1 in attachShadow after renaming CustomElement to CustomElementV0. BUG=531990,621942 ==========
Description was changed from ========== Allow Custom Element v1 to call attachShadow It looks no once has not supported Custom Elements v1 in attachShadow after renaming CustomElement to CustomElementV0. BUG=531990,621942 ========== to ========== Support Custom Elements v1 in attachShadow After renaming CustomElement to CustomElementV0, the support of Custom Elements v1 in attachShadow looks forgotten. Fix it. BUG=531990,621942 ==========
Description was changed from ========== Support Custom Elements v1 in attachShadow After renaming CustomElement to CustomElementV0, the support of Custom Elements v1 in attachShadow looks forgotten. Fix it. BUG=531990,621942 ========== to ========== Support Custom Elements v1 in attachShadow After renaming CustomElement to CustomElementV0, the support of Custom Elements v1 in attachShadow looks forgotten. Fix it. BUG=531990,621942 ==========
hayato@chromium.org changed reviewers: + dominicc@chromium.org, kochi@chromium.org, kojii@chromium.org
PTAL
Description was changed from ========== Support Custom Elements v1 in attachShadow After renaming CustomElement to CustomElementV0, the support of Custom Elements v1 in attachShadow looks forgotten. Fix it. BUG=531990,621942 ========== to ========== Support Custom Elements v1 in attachShadow After renaming CustomElement to CustomElementV0, it looks the support of Custom Elements v1 in attachShadow has been forgotten. Fix it. BUG=531990,621942 ==========
Description was changed from ========== Support Custom Elements v1 in attachShadow After renaming CustomElement to CustomElementV0, it looks the support of Custom Elements v1 in attachShadow has been forgotten. Fix it. BUG=531990,621942 ========== to ========== Support Custom Elements v1 in attachShadow After renaming CustomElement to CustomElementV0, it looks the support of Custom Elements v1 in attachShadow has been forgotten. Fix it. BUG=531990,621942 ==========
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, thanks for fixing this. Nit: nice if test had coverage of <x-foo> without define(). Elements with valid custom element name should be isCustomElement() too.
On 2016/06/23 at 13:44:20, kojii wrote: > lgtm, thanks for fixing this. > > Nit: nice if test had coverage of <x-foo> without define(). Elements with valid custom element name should be isCustomElement() too. That is covered. See line 7 of shadow-dom/attach-shadow-safelist.html
The CQ bit was checked by hayato@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092703002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Support Custom Elements v1 in attachShadow After renaming CustomElement to CustomElementV0, it looks the support of Custom Elements v1 in attachShadow has been forgotten. Fix it. BUG=531990,621942 ========== to ========== Support Custom Elements v1 in attachShadow After renaming CustomElement to CustomElementV0, it looks the support of Custom Elements v1 in attachShadow has been forgotten. Fix it. BUG=531990,621942 Committed: https://crrev.com/fa38a0afc1d55a8a625b87514d4799877c2d2ef7 Cr-Commit-Position: refs/heads/master@{#401779} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fa38a0afc1d55a8a625b87514d4799877c2d2ef7 Cr-Commit-Position: refs/heads/master@{#401779} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
