Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2092673002: Fix recomputing LibraryElement.exportNamespace. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix recomputing LibraryElement.exportNamespace. This caused the bogus warnings in Flutter. 1. object.dart exports painting.dart 2. painting.dart exports box_painter.dart 3. When the user changes box_painter.dart, we correctly invalidate LIBRARY_ELEMENT4, which contains LibraryElement.exportNamespace. 4. When BuildExportNamespaceTask recomputes LIBRARY_ELEMENT4, and recomputes exportNamespace for the library... it calls NamespaceBuilder.createExportNamespaceForLibrary(), which uses the cached LibraryElement.exportNamespace, which we don't flush. R=brianwilkerson@google.com, pquitslund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/662a461988b5097a0e7f48628e4330aaf9447b59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 6 months ago (2016-06-23 05:04:50 UTC) #1
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-23 13:14:54 UTC) #2
scheglov
4 years, 6 months ago (2016-06-23 15:39:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
662a461988b5097a0e7f48628e4330aaf9447b59 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698