Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2092603002: DCHECK that GuestViewDetachRequest receives GuestViewMsg_GuestDetached IPC. (Closed)

Created:
4 years, 6 months ago by lazyboy
Modified:
4 years, 6 months ago
Reviewers:
EhsanK
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DCHECK that GuestViewDetachRequest receives GuestViewMsg_GuestDetached IPC. Couple of reasons: 1. GuestViewDetachRequest should only receive that IPC. 2. Make it clear that the IPC has a consumer/handler. BUG=609188 Committed: https://crrev.com/193f4598c1dcbfba2024b70578016d2239458cee Cr-Commit-Position: refs/heads/master@{#401480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/guest_view/renderer/guest_view_request.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
lazyboy
4 years, 6 months ago (2016-06-23 00:02:13 UTC) #2
EhsanK
On 2016/06/23 00:02:13, lazyboy wrote: lgtm.
4 years, 6 months ago (2016-06-23 00:12:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092603002/1
4 years, 6 months ago (2016-06-23 00:26:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 00:33:13 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 00:35:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/193f4598c1dcbfba2024b70578016d2239458cee
Cr-Commit-Position: refs/heads/master@{#401480}

Powered by Google App Engine
This is Rietveld 408576698