Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2092533003: [ced] Suppress a compiler warning on Windows (Closed)

Created:
4 years, 6 months ago by Jinsuk Kim
Modified:
4 years, 6 months ago
CC:
aelias_OOO_until_Jul13, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ced] Suppress a compiler warning on Windows Added a new option suppressing MSVC compiler warning: '<': signed/unsigned mismatch for the places where a signed int is used for a loop variable against unsigned int upper limit. This is necessary for Windows build. BUG=597488 Committed: https://crrev.com/fdad2babe0c8940a094e0b77b1ac75bbb2fbc819 Cr-Commit-Position: refs/heads/master@{#401492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/ced/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Jinsuk Kim
4 years, 6 months ago (2016-06-22 23:10:27 UTC) #2
Jinsuk Kim
Let me check in this now, since the amount of change is trivial. lgtm
4 years, 6 months ago (2016-06-23 00:53:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092533003/1
4 years, 6 months ago (2016-06-23 00:54:28 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-23 00:54:31 UTC) #7
aelias_OOO_until_Jul13
My lgtm should work.
4 years, 6 months ago (2016-06-23 00:58:45 UTC) #9
Jinsuk Kim
On 2016/06/23 00:58:45, aelias wrote: > My lgtm should work. Thanks. trying again...
4 years, 6 months ago (2016-06-23 00:59:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092533003/1
4 years, 6 months ago (2016-06-23 00:59:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 01:05:15 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 01:09:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdad2babe0c8940a094e0b77b1ac75bbb2fbc819
Cr-Commit-Position: refs/heads/master@{#401492}

Powered by Google App Engine
This is Rietveld 408576698