ui/native_theme/BUILD.gn - Issue 2092513002: [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics is linked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/native_theme/BUILD.gn

Issue 2092513002: [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics is linked. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/native_theme/BUILD.gn

diff --git a/ui/native_theme/BUILD.gn b/ui/native_theme/BUILD.gn

index b79e1131c2a6130c8c6db74ee99af5791b225007..d5020fb6cfa83865209b02acc38c35e9bc9e85a3 100644

--- a/ui/native_theme/BUILD.gn

+++ b/ui/native_theme/BUILD.gn

@@ -58,8 +58,9 @@ component("native_theme") {

if (is_mac) {

libs = [

- "CoreGraphics.framework",

"AppKit.framework",

+ "ApplicationServices.framework", # Temporary hack around https://crbug.com/620127. Remove after https://crbug.com/622481 is fixed.

+ "CoreGraphics.framework",

]

}

« no previous file with comments | « ui/gfx/BUILD.gn ('k') | ui/snapshot/BUILD.gn » ('j') | no next file with comments »