skia/BUILD.gn - Issue 2092513002: [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics is linked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/BUILD.gn

Issue 2092513002: [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics is linked. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: skia/BUILD.gn

diff --git a/skia/BUILD.gn b/skia/BUILD.gn

index 2c9d9de43720cc6850188ca3bd91824aea7d5571..2ea75d37f7a8e21d07a22178c9419618e04b4406 100644

--- a/skia/BUILD.gn

+++ b/skia/BUILD.gn

@@ -522,6 +522,7 @@ component("skia") {

if (is_mac) {

libs = [

"AppKit.framework",

+ "ApplicationServices.framework", # Temporary hack around https://crbug.com/620127. Remove after https://crbug.com/622481 is fixed.

"CoreFoundation.framework",

"CoreGraphics.framework",

"CoreText.framework",

« no previous file with comments | « media/capture/BUILD.gn ('k') | ui/accelerated_widget_mac/BUILD.gn » ('j') | no next file with comments »