gpu/ipc/service/BUILD.gn - Issue 2092513002: [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics is linked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/ipc/service/BUILD.gn

Issue 2092513002: [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics is linked. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/ipc/service/BUILD.gn

diff --git a/gpu/ipc/service/BUILD.gn b/gpu/ipc/service/BUILD.gn

index 34a1ac62e38efedd8e6c8182edde9b0095f2cc7b..f3b357046e8848c18da3545d748ef0943deb22f8 100644

--- a/gpu/ipc/service/BUILD.gn

+++ b/gpu/ipc/service/BUILD.gn

@@ -78,8 +78,9 @@ source_set("ipc_service_sources") {

deps += [ "//ui/accelerated_widget_mac" ]

lib_dirs = [ "$mac_sdk_path/usr/lib" ]

libs += [

- "QuartzCore.framework",

+ "ApplicationServices.framework", # Temporary hack around https://crbug.com/620127.

Mark Mentovai 2016/06/22 21:09:05 >80 OK in .gn?

Robert Sesek 2016/06/22 22:13:43 GN format didn't complain. Putting the comment abo

"CoreGraphics.framework",

+ "QuartzCore.framework",

]

}

if (is_android) {

« no previous file with comments | « no previous file | media/BUILD.gn » ('j') | no next file with comments »