Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2092493002: [crankshaft] Re-add kAllowUndefinedAsNaN flag for bitwise binary ops (Closed)

Created:
4 years, 6 months ago by adamk
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Re-add kAllowUndefinedAsNaN flag for bitwise binary ops It appears to have been dropped accidentally as part of 1150092b29's removal of strong mode for binary ops. Committed: https://crrev.com/8c0ee440c1df1c759c579d9336ff681279ae9568 Cr-Commit-Position: refs/heads/master@{#37229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/crankshaft/hydrogen-instructions.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
Found this while doing some archeology on hydrogen.cc. See https://codereview.chromium.org/1693833002/diff/100001/src/crankshaft/hydrogen-instructions.h#oldcode4106 for how the code got ...
4 years, 6 months ago (2016-06-22 20:02:01 UTC) #2
Benedikt Meurer
LGTM, although I don't think it matters since the bitwise operations are truncating-to-int32, which is ...
4 years, 6 months ago (2016-06-23 03:49:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092493002/1
4 years, 6 months ago (2016-06-23 21:03:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 21:35:31 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 21:36:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c0ee440c1df1c759c579d9336ff681279ae9568
Cr-Commit-Position: refs/heads/master@{#37229}

Powered by Google App Engine
This is Rietveld 408576698