Provide access to the ID for the remoted Windows session in the network process

Provide access to the ID for the remoted Windows session in the network process

This change updates the DesktopSessionProxy (which maintains an IPC connection
with the desktop process) to query for the session ID when connection its IPC
channel.  This session ID is then plumbed through the desktop environment
classes for use by the ClientSession in a later CL.

BUG=591746
Committed: https://crrev.com/90b28f848da4cd039cc7183f1c580e4b52cef84e
Cr-Commit-Position: refs/heads/master@{#401815}

[Sergey Ulanov, 2016-06-23 22:35:53]

sergeyu@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2016-06-23 22:35:54]

lgtm

https://codereview.chromium.org/2092483002/diff/20001/remoting/host/desktop_e...
File remoting/host/desktop_environment.h (right):

https://codereview.chromium.org/2092483002/diff/20001/remoting/host/desktop_e...
remoting/host/desktop_environment.h:58: // Returns an id which identifies the
current desktop session.
Please make it clear that this ID is platform-specific and we don't expect it to
be set on all platforms (in which case it's UINT32_MAX)

https://codereview.chromium.org/2092483002/diff/20001/remoting/host/desktop_s...
File remoting/host/desktop_session_proxy.cc (right):

https://codereview.chromium.org/2092483002/diff/20001/remoting/host/desktop_s...
remoting/host/desktop_session_proxy.cc:205: if (!ProcessIdToSessionId(peer_pid,
Can we assume that the session_id will never change for duration of the session?

https://codereview.chromium.org/2092483002/diff/20001/remoting/host/desktop_s...
remoting/host/desktop_session_proxy.cc:206:
reinterpret_cast<DWORD*>(&desktop_session_id_))) {
Do you need this cast? DWORD should be equivalent to uint32_t, so I don't think
it's necessary.

[joedow, 2016-06-23 23:26:03]

joedow@chromium.org changed reviewers:
+ zijiehe@chromium.org

[joedow, 2016-06-23 23:26:03]

joedow@chromium.org changed required reviewers:
+ sergeyu@chromium.org

[joedow, 2016-06-23 23:26:04]

Addressed feedback, thanks for the speedy review!

https://codereview.chromium.org/2092483002/diff/20001/remoting/host/desktop_e...
File remoting/host/desktop_environment.h (right):

https://codereview.chromium.org/2092483002/diff/20001/remoting/host/desktop_e...
remoting/host/desktop_environment.h:58: // Returns an id which identifies the
current desktop session.
On 2016/06/23 22:35:53, Sergey Ulanov wrote:
> Please make it clear that this ID is platform-specific and we don't expect it
to
> be set on all platforms (in which case it's UINT32_MAX)

Done.

https://codereview.chromium.org/2092483002/diff/20001/remoting/host/desktop_s...
File remoting/host/desktop_session_proxy.cc (right):

https://codereview.chromium.org/2092483002/diff/20001/remoting/host/desktop_s...
remoting/host/desktop_session_proxy.cc:205: if (!ProcessIdToSessionId(peer_pid,
On 2016/06/23 22:35:53, Sergey Ulanov wrote:
> Can we assume that the session_id will never change for duration of the
session?

The session ID will never change for the desktop_host/remoting_host process the
proxy is connected to.  Sessions do change, but a new process/proxy is created
and used by the network process when that occurs.

https://codereview.chromium.org/2092483002/diff/20001/remoting/host/desktop_s...
remoting/host/desktop_session_proxy.cc:206:
reinterpret_cast<DWORD*>(&desktop_session_id_))) {
On 2016/06/23 22:35:53, Sergey Ulanov wrote:
> Do you need this cast? DWORD should be equivalent to uint32_t, so I don't
think
> it's necessary.

You would think it would be unnecessary but compilation fails if I don't:
remoting\host\desktop_session_proxy.cc(205): error C2664: 'BOOL
ProcessIdToSessionId(DWORD,DWORD *)': cannot convert argument 2 from 'uint32_t
*' to 'DWORD *'
remoting\host\desktop_session_proxy.cc(205): note: Types pointed to are
unrelated; conversion requires reinterpret_cast, C-style cast or function-style
cast

[joedow, 2016-06-24 03:38:20]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-06-24 03:38:20]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2092483002/#ps40001
(title: "Addressing CR Feedback")

[commit-bot: I haz the power, 2016-06-24 03:38:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2092483002/40001

[commit-bot: I haz the power, 2016-06-24 04:46:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-24 04:48:02]

Description was changed from

==========
Provide access to the ID for the remoted Windows session in the network process

This change updates the DesktopSessionProxy (which maintains an IPC connection
with the desktop process) to query for the session ID when connection its IPC
channel.  This session ID is then plumbed through the desktop environment
classes for use by the ClientSession in a later CL.

BUG=591746
==========

to

==========
Provide access to the ID for the remoted Windows session in the network process

This change updates the DesktopSessionProxy (which maintains an IPC connection
with the desktop process) to query for the session ID when connection its IPC
channel.  This session ID is then plumbed through the desktop environment
classes for use by the ClientSession in a later CL.

BUG=591746

Committed: https://crrev.com/90b28f848da4cd039cc7183f1c580e4b52cef84e
Cr-Commit-Position: refs/heads/master@{#401815}
==========

[commit-bot: I haz the power, 2016-06-24 04:48:04]

Patchset 3 (id:??) landed as
https://crrev.com/90b28f848da4cd039cc7183f1c580e4b52cef84e
Cr-Commit-Position: refs/heads/master@{#401815}