services/preferences/public/cpp/BUILD.gn - Issue 2092453002: Mojom interface for Preferences

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/preferences/public/cpp/BUILD.gn

Issue 2092453002: Mojom interface for Preferences (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switch to using DictionaryValue Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("input_devices") {	5 source_set("cpp") {

6 sources = [	6 sources = [

7 "input_device_client.cc",	7 "pref_observer_store.cc",

8 "input_device_client.h",	8 "pref_observer_store.h",

	9 "preferences_export.h",
	sadrul 2016/10/06 14:09:41 Doesn't looks like this file is in the CL? But do Doesn't looks like this file is in the CL? But do you actually need to export? jonross 2016/10/06 21:36:20 It's not anymore, and export not needed for source Show quoted text On 2016/10/06 14:09:41, sadrul wrote: > Doesn't looks like this file is in the CL? But do you actually need to export? It's not anymore, and export not needed for source_set. Missed removing it here.
	10 ]

	11

	12 public_deps = [

	13 "//base",

	14 "//components/prefs:prefs",

	15 "//services/preferences/public/interfaces",

	16 "//services/shell/public/cpp",

9 ]	17 ]

10	18

11 deps = [	19 deps = [

12 "//base",	20 "//mojo/public/cpp/bindings:bindings",

13 "//services/shell/public/cpp",

14 "//ui/events/devices",

15 ]

16

17 public_deps = [

18 "//services/ui/public/interfaces/input_devices",

19 ]	21 ]

20 }	22 }

OLD	NEW