|
|
Chromium Code Reviews
Description[perf] Change google.com to google.ca in top_10_mobile page set.
In the top10_mobile page set google.com gets redirected to google.ca.
This sometimes causes problems in telemetry with scrolling. As a short term
fix, replace google.com with google.ca in the page set.
BUG=chromium:617914
LOG=N
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Committed: https://crrev.com/d0c95636111161400a576472427de8eeb2330d43
Cr-Commit-Position: refs/heads/master@{#401863}
Patch Set 1 #Patch Set 2 : Fixed few more that are dependent on the same pageset. #
Messages
Total messages: 31 (16 generated)
Description was changed from ========== Change google.com to google.ca to avoid problems due to redirection. In the top10_mobile_memory pageset google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the pageset. BUG=chromium:617914 LOG=N ========== to ========== Change google.com to google.ca to avoid problems due to redirection. In the top10_mobile_memory pageset google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the pageset. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092443002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092443002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092443002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mythria@chromium.org changed reviewers: + petrcermak@chromium.org
Hi Petr, I changed google.com to google.ca to avoid problems with scrolling due to redirection. PTAL. Could you also add someone from telemetry for review? Thanks, Mythri
petrcermak@chromium.org changed reviewers: + nednguyen@google.com
LGTM. Out of curiosity, what does "LOG=N" in the patch description mean? I haven't seen it anywhere else. +nednguyen (owner) Thanks, Petr
Oh and I suggest you change the patch description to "[perf] Change google.com to google.ca in top_10_mobile page set" (people outside performance might be wondering what this patch means). Thanks, Petr
Description was changed from ========== Change google.com to google.ca to avoid problems due to redirection. In the top10_mobile_memory pageset google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the pageset. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Change google.com to google.ca to avoid problems due to redirection. In the top10_mobile_memory pageset google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the pageset. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== [perf] Change google.com to google.ca to avoid problems due to redirection. In the top10_mobile_memory pageset google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the pageset. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Change google.com to google.ca in top_10_mobile_memory pageset. In the top10_mobile_memory pageset google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the pageset. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== [perf] Change google.com to google.ca in top_10_mobile_memory pageset. In the top10_mobile_memory pageset google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the pageset. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Change google.com to google.ca in top_10_mobile page set. In the top10_mobile_memory pageset google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the pageset. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== [perf] Change google.com to google.ca in top_10_mobile page set. In the top10_mobile_memory pageset google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the pageset. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Change google.com to google.ca in top_10_mobile page set. In the top10_mobile page set google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the page set. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Thanks Petr. Updated the description. I think LOG=N means that this need not be logged in release notes or something similar. When I have a BUG=xxx it usually complains if I do not add LOG=Y/N.
lgtm
The CQ bit was checked by mythria@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [perf] Change google.com to google.ca in top_10_mobile page set. In the top10_mobile page set google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the page set. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Change google.com to google.ca in top_10_mobile page set. In the top10_mobile page set google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the page set. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [perf] Change google.com to google.ca in top_10_mobile page set. In the top10_mobile page set google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the page set. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Change google.com to google.ca in top_10_mobile page set. In the top10_mobile page set google.com gets redirected to google.ca. This sometimes causes problems in telemetry with scrolling. As a short term fix, replace google.com with google.ca in the page set. BUG=chromium:617914 LOG=N CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/d0c95636111161400a576472427de8eeb2330d43 Cr-Commit-Position: refs/heads/master@{#401863} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d0c95636111161400a576472427de8eeb2330d43 Cr-Commit-Position: refs/heads/master@{#401863}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2112583002/ by perezju@chromium.org. The reason for reverting is: Caused artificial memory drop in memory.top_10_mobile benchmark. Sorry if this breaks or flakes other benchmarks. We can re-land (with re-recorded pages) when the dust settles after health plan for this milestone is completed.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
