Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: content/public/browser/web_contents.h

Issue 20924002: Try to restore window.opener when opening blocked popups (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index b7f67e46eaef8e423c4d24d3ff9753bdd5ed2de1..2dc081e3ccd483c0d1c5e01a51e6cfbce20129df 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -56,7 +56,7 @@ struct RendererPreferences;
// Instantiating one is simple:
// scoped_ptr<content::WebContents> web_contents(
// content::WebContents::Create(
-// content::WebContents::CreateParams(browser_context)));
+// content::WebContents::CreateParams(browser_context), NULL));
// gfx::NativeView view = web_contents->GetView()->GetNativeView();
// // |view| is an HWND, NSView*, GtkWidget*, etc.; insert it into the view
// // hierarchy wherever it needs to go.
@@ -91,8 +91,10 @@ class WebContents : public PageNavigator,
gfx::NativeView context;
};
- // Creates a new WebContents.
- CONTENT_EXPORT static WebContents* Create(const CreateParams& params);
+ // Creates a new WebContents. If |opener| is non-NULL, it will be set as the
+ // WebContent's opener.
+ CONTENT_EXPORT static WebContents* Create(const CreateParams& params,
+ WebContents* opener = NULL);
awong 2013/07/31 20:21:42 default args aren't allowed by style guide. Maybe
jochen (gone - plz use gerrit) 2013/07/31 20:23:44 The default arg is just there to make it possible
// Similar to Create() above but should be used when you need to prepopulate
// the SessionStorageNamespaceMap of the WebContents. This can happen if

Powered by Google App Engine
This is Rietveld 408576698