Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/data/popup_blocker/check-sessionstorage.html

Issue 20924002: Try to restore window.opener when opening blocked popups (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/browser_navigator.h ('K') | « chrome/test/data/popup_blocker/check-openersuppressed.html ('k') | chrome/test/data/popup_blocker/popup-opener.html » ('j') | chrome/test/data/popup_blocker/popup-sessionstorage.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/popup_blocker/check-sessionstorage.html
diff --git a/chrome/test/data/popup_blocker/check-windowfeatures.html b/chrome/test/data/popup_blocker/check-sessionstorage.html
similarity index 58%
copy from chrome/test/data/popup_blocker/check-windowfeatures.html
copy to chrome/test/data/popup_blocker/check-sessionstorage.html
index 901ce081aa02e67325474829ae1533837e59fe2d..8a46ddc65da6a3ce405e3f852c069d63d8600f4d 100644
--- a/chrome/test/data/popup_blocker/check-windowfeatures.html
+++ b/chrome/test/data/popup_blocker/check-sessionstorage.html
@@ -1,15 +1,15 @@
<!DOCTYPE html>
<html>
<head>
-<title>Check that window features are set</title>
+<title>Check that the session storage namespace is correct</title>
awong 2013/07/31 20:21:42 is accessible is maybe better?
Charlie Reis 2013/08/01 18:13:34 Not accessible, right? The test below is making s
jochen (gone - plz use gerrit) 2013/08/01 19:48:51 Done.
</head>
<body>
<div id="console"></div>
<script>
var log = document.querySelector("#console");
var result;
- if (window.locationbar.visible)
- result = "FAIL: window features not set";
+ if (sessionStorage.getItem("key") == "set")
+ result = "FAIL: popup can access session storage namespace";
else
result = "PASS";
log.innerText = result;
« chrome/browser/ui/browser_navigator.h ('K') | « chrome/test/data/popup_blocker/check-openersuppressed.html ('k') | chrome/test/data/popup_blocker/popup-opener.html » ('j') | chrome/test/data/popup_blocker/popup-sessionstorage.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698