Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Unified Diff: content/browser/web_contents/navigation_controller_impl.cc

Issue 20924002: Try to restore window.opener when opening blocked popups (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/navigation_controller_impl.cc
diff --git a/content/browser/web_contents/navigation_controller_impl.cc b/content/browser/web_contents/navigation_controller_impl.cc
index 6176606cbd44d6bbaeb66e9ee368e57bcd2ac80a..8bcd7a116d56e2f939c8476b40fa0981465708ae 100644
--- a/content/browser/web_contents/navigation_controller_impl.cc
+++ b/content/browser/web_contents/navigation_controller_impl.cc
@@ -691,6 +691,11 @@ void NavigationControllerImpl::LoadURLWithParams(const LoadURLParams& params) {
entry->set_transferred_global_request_id(
params.transferred_global_request_id);
entry->SetFrameToNavigate(params.frame_name);
+ if (params.should_stay_in_site_instance) {
Charlie Reis 2013/07/31 17:16:16 I don't think we should have this, since it makes
jochen (gone - plz use gerrit) 2013/07/31 18:30:52 Removed this code.
+ entry->set_site_instance(
+ static_cast<SiteInstanceImpl*>(web_contents_->GetSiteInstance()));
+ CHECK(!entry->site_instance()->HasWrongProcessForURL(params.url));
+ }
switch (params.load_type) {
case LOAD_TYPE_DEFAULT:

Powered by Google App Engine
This is Rietveld 408576698