chrome/test/data/popup_blocker/check-sessionstorage.html - Issue 20924002: Try to restore window.opener when opening blocked popups - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(7478)

My Issues | Starred Open | Closed | All

Unified Diff: chrome/test/data/popup_blocker/check-sessionstorage.html

Issue 20924002: Try to restore window.opener when opening blocked popups (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sessionStorage+opener Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/ui/browser_navigator.cc ('K') | « chrome/browser/ui/browser_navigator.cc ('k') | chrome/test/data/popup_blocker/popup-sessionstorage.html » ('j') | content/browser/web_contents/render_view_host_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/popup_blocker/check-sessionstorage.html

diff --git a/chrome/test/data/popup_blocker/check-windowfeatures.html b/chrome/test/data/popup_blocker/check-sessionstorage.html

similarity index 57%

copy from chrome/test/data/popup_blocker/check-windowfeatures.html

copy to chrome/test/data/popup_blocker/check-sessionstorage.html

index 901ce081aa02e67325474829ae1533837e59fe2d..15f865c1b5f04f6b27df2800b84fb99251e7f4bd 100644

--- a/chrome/test/data/popup_blocker/check-windowfeatures.html

+++ b/chrome/test/data/popup_blocker/check-sessionstorage.html

@@ -1,17 +1,17 @@

<!DOCTYPE html>

<html>

<head>

-<title>Check that window features are set</title>

+<title>Check that the session storage namespace is correct</title>

</head>

<body>

<div id="console"></div>

<script>

var log = document.querySelector("#console");

var result;

- if (window.locationbar.visible)

- result = "FAIL: window features not set";

- else

+ if (sessionStorage.getItem("key") == "set")

result = "PASS";

+ else

+ result = "FAIL: popup has a different session storage namespace";

log.innerText = result;

document.title = result;

</script>

« chrome/browser/ui/browser_navigator.cc ('K') | « chrome/browser/ui/browser_navigator.cc ('k') | chrome/test/data/popup_blocker/popup-sessionstorage.html » ('j') | content/browser/web_contents/render_view_host_manager.cc » ('J')

Powered by Google App Engine

This is Rietveld 408576698