chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc - Issue 20924002: Try to restore window.opener when opening blocked popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

Issue 20924002: Try to restore window.opener when opening blocked popups (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updates Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

diff --git a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

index ee2852c9168010a94bdb6b024811f0ffc12bba93..7212baecbdcfd432454f6d868dee28d7a9d2a594 100644

--- a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

+++ b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

@@ -109,6 +109,7 @@ void PopupBlockerTabHelper::AddBlockedPopup(

nav_params.tabstrip_add_types = TabStripModel::ADD_ACTIVE;

nav_params.window_action = chrome::NavigateParams::SHOW_WINDOW;

nav_params.user_gesture = user_gesture;

+ nav_params.should_set_opener = !opener_suppressed;

web_contents()->GetView()->GetContainerBounds(&nav_params.window_bounds);

if (features.xSet)

nav_params.window_bounds.set_x(features.x);