Try to restore window.opener when opening blocked popups

content/public/browser/web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 38 matching lines @@
 class WebContentsDelegate;
 class WebContentsView;
 struct RendererPreferences;
 
 // WebContents is the core class in content/. A WebContents renders web content
 // (usually HTML) in a rectangular area.
 //
 // Instantiating one is simple:
 //   scoped_ptr<content::WebContents> web_contents(
 //       content::WebContents::Create(
-//           content::WebContents::CreateParams(browser_context)));
+//           content::WebContents::CreateParams(browser_context), NULL));
 //   gfx::NativeView view = web_contents->GetView()->GetNativeView();
 //   // |view| is an HWND, NSView*, GtkWidget*, etc.; insert it into the view
 //   // hierarchy wherever it needs to go.
 //
 // That's it; go to your kitchen, grab a scone, and chill. WebContents will do
 // all the multi-process stuff behind the scenes. More details are at
 // http://www.chromium.org/developers/design-documents/multi-process-architecture .
 //
 // Each WebContents has exactly one NavigationController; each
 // NavigationController belongs to one WebContents. The NavigationController can
@@ skipping 14 matching lines @@
     int main_frame_routing_id;
 
     // Initial size of the new WebContent's view. Can be (0, 0) if not needed.
     gfx::Size initial_size;
 
     // Used to specify the location context which display the new view should
     // belong. This can be NULL if not needed.
     gfx::NativeView context;
   };
 
-  // Creates a new WebContents.
-  CONTENT_EXPORT static WebContents* Create(const CreateParams& params);
+  // Creates a new WebContents. If |opener| is non-NULL, it will be set as the
+  // WebContent's opener.
+  CONTENT_EXPORT static WebContents* Create(const CreateParams& params,
+                                            WebContents* opener = NULL);

[awong, 2013/07/31 20:21:42]

default args aren't allowed by style guide.  Maybe add a CreateWithOpener()

[jochen (gone - plz use gerrit), 2013/07/31 20:23:44]

The default arg is just there to make it possible to find the actual code to
review. I'll remove the default parameter if you like the actual code.

 
   // Similar to Create() above but should be used when you need to prepopulate
   // the SessionStorageNamespaceMap of the WebContents. This can happen if
   // you duplicate a WebContents, try to reconstitute it from a saved state,
   // or when you create a new WebContents based on another one (eg., when
   // servicing a window.open() call).
   //
   // You do not want to call this. If you think you do, make sure you completely
   // understand when SessionStorageNamespace objects should be cloned, why
   // they should not be shared by multiple WebContents, and what bad things
@@ skipping 346 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class WebContentsImpl;
   WebContents() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_