chrome/test/data/popup_blocker/check-sessionstorage.html - Issue 20924002: Try to restore window.opener when opening blocked popups

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/popup_blocker/check-sessionstorage.html

Issue 20924002: Try to restore window.opener when opening blocked popups (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updates Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/browser_navigator.h ('K') | « chrome/test/data/popup_blocker/check-openersuppressed.html ('k') | chrome/test/data/popup_blocker/popup-opener.html » ('j') | chrome/test/data/popup_blocker/popup-sessionstorage.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Check that window features are set</title>	4 <title>Check that the session storage namespace is correct</title>
	awong 2013/07/31 20:21:42 is accessible is maybe better? is accessible is maybe better? Charlie Reis 2013/08/01 18:13:34 Not accessible, right? The test below is making s Show quoted text On 2013/07/31 20:21:42, awong wrote: > is accessible is maybe better? Not accessible, right? The test below is making sure you can't access the namespace of the opener tab. jochen (gone - plz use gerrit) 2013/08/01 19:48:51 Done. Show quoted text On 2013/08/01 18:13:34, creis wrote: > On 2013/07/31 20:21:42, awong wrote: > > is accessible is maybe better? > > Not accessible, right? The test below is making sure you can't access the > namespace of the opener tab. Done.
5 </head>	5 </head>

6 <body>	6 <body>

7 <div id="console"></div>	7 <div id="console"></div>

8 <script>	8 <script>

9 var log = document.querySelector("#console");	9 var log = document.querySelector("#console");

10 var result;	10 var result;

11 if (window.locationbar.visible)	11 if (sessionStorage.getItem("key") == "set")

12 result = "FAIL: window features not set";	12 result = "FAIL: popup can access session storage namespace";

13 else	13 else

14 result = "PASS";	14 result = "PASS";

15 log.innerText = result;	15 log.innerText = result;

16 document.title = result;	16 document.title = result;

17 </script>	17 </script>

18 </body>	18 </body>

19 </html>	19 </html>

OLD	NEW