Try to restore window.opener when opening blocked popups

content/browser/web_contents/render_view_host_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/renderer_host/test_render_view_host.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/browser/web_contents/navigation_controller_impl.h"
 #include "content/browser/web_contents/navigation_entry_impl.h"
 #include "content/browser/web_contents/render_view_host_manager.h"
@@ skipping 1193 matching lines @@
   EXPECT_FALSE(manager.pending_render_view_host());
 
   // Commit.
   manager.DidNavigateMainFrame(host);
   EXPECT_EQ(host, manager.current_host());
   ASSERT_TRUE(host);
   EXPECT_EQ(static_cast<SiteInstanceImpl*>(host->GetSiteInstance()),
       instance);
 }
 
+// Tests that when specified, a navigation is done in the site instance of the

[Charlie Reis, 2013/07/31 17:16:16]

I do not think we should have this behavior.

[jochen (gone - plz use gerrit), 2013/07/31 18:30:52]

Removed.

+// owning WebContents.
+TEST_F(RenderViewHostManagerTest, StayWithinSiteInstance) {
+  const GURL kUrl1("http://www.google.com/");
+  const GURL kUrl2("http://www.chromium.org/");
+
+  // Create a WebContents with a SiteInstance corresponding to kUrl1.
+  scoped_refptr<SiteInstance> site_instance(
+      SiteInstance::CreateForURL(browser_context(), kUrl1));
+  scoped_ptr<TestWebContents> contents2(
+      TestWebContents::Create(browser_context(), site_instance.get()));
+
+  // Navigate to kUrl2, but specify that we want to use the existing
+  // SiteInstance.
+  NavigationController::LoadURLParams params(kUrl2);
+  params.transition_type = PAGE_TRANSITION_LINK;
+  params.should_stay_in_site_instance = true;
+  contents2->GetController().LoadURLWithParams(params);
+
+  // Check that the RVH was created with the desired SiteInstance.
+  TestRenderViewHost* dest_rvh =
+      static_cast<TestRenderViewHost*>(contents2->GetRenderViewHost());
+  ASSERT_TRUE(dest_rvh);
+  EXPECT_EQ(site_instance.get(), dest_rvh->GetSiteInstance());
+}
+
 }  // namespace content