Convert video-src* tests to testharness.js

Convert video-src* tests to testharness.js

Cleaning up video-src* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/daaf3e5be2b53be7a8e19f40b2ab9bfbe844e12d
Cr-Commit-Position: refs/heads/master@{#402077}

[Srirama, 2016-06-25 14:56:41]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert video-src* tests to testharness.js

Cleaning up video-src* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-06-25 15:19:13]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-06-25 15:19:14]

PTAL

[fs, 2016-06-25 17:12:03]

LGTM w/ some minor comments

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-src-change.html (right):

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-change.html:21: if (++loadedCount
>= 2) {
Should never be > 2, right?

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-change.html:30: var url =
video.currentSrc;
Assert loadedCount == 0 too?

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-change.html:39: function
setSrcAttribure(src) {
Let's fix this typo while we're at it (...bure -> ...bute)

Or maybe just open-code this.

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-src-empty.html (right):

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-empty.html:19: video.src = "";
Maybe it would be better to start out with onerror as "unreachable" and then
update it here to what we have below?

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-empty.html:22: video.onerror =
t.step_func_done(function() {
Nit: Add 'event' as argument?

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-src.html (right):

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src.html:2: <title>Video element with
src="" should invoke media element's load algorithm and should fire "error"
event. Network state should be NETWORK_NO_SOURCE and the error code should be
MEDIA_ERR_SRC_NOT_SUPPORTED.</title>
Hmm?

[Srirama, 2016-06-26 05:41:55]

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-src-change.html (right):

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-change.html:21: if (++loadedCount
>= 2) {
On 2016/06/25 17:12:03, fs wrote:
> Should never be > 2, right?

Done.

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-change.html:30: var url =
video.currentSrc;
On 2016/06/25 17:12:03, fs wrote:
> Assert loadedCount == 0 too?

Done.

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-change.html:39: function
setSrcAttribure(src) {
On 2016/06/25 17:12:03, fs wrote:
> Let's fix this typo while we're at it (...bure -> ...bute)
> 
> Or maybe just open-code this.

Done.

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-src-empty.html (right):

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-empty.html:19: video.src = "";
On 2016/06/25 17:12:03, fs wrote:
> Maybe it would be better to start out with onerror as "unreachable" and then
> update it here to what we have below?

Done.

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-empty.html:22: video.onerror =
t.step_func_done(function() {
On 2016/06/25 17:12:03, fs wrote:
> Nit: Add 'event' as argument?

Done.

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-src.html (right):

https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src.html:2: <title>Video element with
src="" should invoke media element's load algorithm and should fire "error"
event. Network state should be NETWORK_NO_SOURCE and the error code should be
MEDIA_ERR_SRC_NOT_SUPPORTED.</title>
On 2016/06/25 17:12:03, fs wrote:
> Hmm?

Sorry, copy paste mistake :)

[Srirama, 2016-06-26 05:42:12]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-06-26 05:42:13]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2092373002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-06-26 05:42:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-26 06:55:29]

Description was changed from

==========
Convert video-src* tests to testharness.js

Cleaning up video-src* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-src* tests to testharness.js

Cleaning up video-src* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-06-26 06:55:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-26 06:57:24]

Description was changed from

==========
Convert video-src* tests to testharness.js

Cleaning up video-src* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-src* tests to testharness.js

Cleaning up video-src* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/daaf3e5be2b53be7a8e19f40b2ab9bfbe844e12d
Cr-Commit-Position: refs/heads/master@{#402077}
==========

[commit-bot: I haz the power, 2016-06-26 06:57:25]

Patchset 2 (id:??) landed as
https://crrev.com/daaf3e5be2b53be7a8e19f40b2ab9bfbe844e12d
Cr-Commit-Position: refs/heads/master@{#402077}