Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2092373002: Convert video-src* tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-src* tests to testharness.js Cleaning up video-src* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/daaf3e5be2b53be7a8e19f40b2ab9bfbe844e12d Cr-Commit-Position: refs/heads/master@{#402077}

Patch Set 1 #

Total comments: 12

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -226 lines) Patch
M third_party/WebKit/LayoutTests/media/video-src.html View 1 1 chunk +20 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-src-blob.html View 1 chunk +22 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-src-blob-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-src-change.html View 1 1 chunk +43 lines, -71 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-src-change-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-src-empty.html View 1 1 chunk +27 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-src-empty-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-src-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-25 15:19:14 UTC) #3
fs
LGTM w/ some minor comments https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTests/media/video-src-change.html File third_party/WebKit/LayoutTests/media/video-src-change.html (right): https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTests/media/video-src-change.html#newcode21 third_party/WebKit/LayoutTests/media/video-src-change.html:21: if (++loadedCount >= 2) ...
4 years, 6 months ago (2016-06-25 17:12:03 UTC) #4
Srirama
https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTests/media/video-src-change.html File third_party/WebKit/LayoutTests/media/video-src-change.html (right): https://codereview.chromium.org/2092373002/diff/1/third_party/WebKit/LayoutTests/media/video-src-change.html#newcode21 third_party/WebKit/LayoutTests/media/video-src-change.html:21: if (++loadedCount >= 2) { On 2016/06/25 17:12:03, fs ...
4 years, 5 months ago (2016-06-26 05:41:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2092373002/20001
4 years, 5 months ago (2016-06-26 05:42:24 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-26 06:55:30 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-26 06:57:25 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/daaf3e5be2b53be7a8e19f40b2ab9bfbe844e12d
Cr-Commit-Position: refs/heads/master@{#402077}

Powered by Google App Engine
This is Rietveld 408576698