Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: pkg/analyzer/lib/src/summary/summarize_ast.dart

Issue 2092333002: fix #25794, infer parameter type from default value, in AST summaries (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fix comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/summarize_ast.dart
diff --git a/pkg/analyzer/lib/src/summary/summarize_ast.dart b/pkg/analyzer/lib/src/summary/summarize_ast.dart
index c2a625bf29f69a2ab264da555505f6866af128cf..cb799b93f1a36a4d4e23ed2b08b9605c5406287d 100644
--- a/pkg/analyzer/lib/src/summary/summarize_ast.dart
+++ b/pkg/analyzer/lib/src/summary/summarize_ast.dart
@@ -643,11 +643,17 @@ class _SummarizeAstVisitor extends RecursiveAstVisitor {
b.parameters = formalParameters.parameters
.map((FormalParameter p) => p.accept(this))
.toList();
- if (!isSemanticallyStatic) {
- for (int i = 0; i < formalParameters.parameters.length; i++) {
- if (!b.parameters[i].isFunctionTyped &&
- b.parameters[i].type == null) {
- b.parameters[i].inferredTypeSlot = assignSlot();
+
+ for (int i = 0; i < formalParameters.parameters.length; i++) {
+ UnlinkedParamBuilder p = b.parameters[i];
+ if (!p.isFunctionTyped && p.type == null) {
+ // Strong mode infers parameters in two cases:
+ // - instance members (i.e. not semantically static),
+ // - parameters with default values, except initializing formals
+ // (the type comes from the field).
+ if (!isSemanticallyStatic ||
+ p.initializer != null && !p.isInitializingFormal) {
+ p.inferredTypeSlot = assignSlot();
}
}
}

Powered by Google App Engine
This is Rietveld 408576698