Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 209233004: Revert of implement readPixels and writePixels natively, w/o using the (deprecated) (Closed)

Created:
6 years, 9 months ago by mtklein
Modified:
6 years, 9 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of implement readPixels and writePixels natively, w/o using the (deprecated) (https://codereview.chromium.org/199733016/) Reason for revert: Android bots segfaulting in tests. Original issue's description: > implement readPixels and writePixels natively, w/o using the (deprecated) > SkCanvas::Config8888 enum. > > Revert "Revert "hide Config8888 entirely". Broke a bunch of builds." > > This reverts commit 763277ba157fef0f651004bb98a189e9f1ac730b. > > Needs chrome to remove the READPIXELS guard from skia's .gyp > > Committed: https://code.google.com/p/skia/source/detail?r=13931 TBR=reed@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+643 lines, -454 lines) Patch
M include/core/SkCanvas.h View 3 chunks +0 lines, -8 lines 0 comments Download
M include/core/SkColorPriv.h View 4 chunks +2 lines, -138 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +34 lines, -14 lines 0 comments Download
M src/core/SkConfig8888.h View 1 chunk +65 lines, -17 lines 0 comments Download
M src/core/SkConfig8888.cpp View 1 chunk +275 lines, -112 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +75 lines, -42 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +5 lines, -16 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 7 chunks +21 lines, -6 lines 0 comments Download
M tests/WritePixelsTest.cpp View 9 chunks +120 lines, -99 lines 0 comments Download
M tools/sk_tool_utils.h View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/sk_tool_utils.cpp View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of implement readPixels and writePixels natively, w/o using the (deprecated)
6 years, 9 months ago (2014-03-25 13:38:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/209233004/1
6 years, 9 months ago (2014-03-25 13:38:29 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 13:38:59 UTC) #3
Message was sent while issue was closed.
Change committed as 13932

Powered by Google App Engine
This is Rietveld 408576698