chrome/app/generated_resources.grd - Issue 2092293002: Block framebusts without a user gesture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 2092293002: Block framebusts without a user gesture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 23038902d3181492765e3198fed5e91a552557d2..61afcd877dd3edf87146dd7a821f70b9e2ed0bda 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -15204,7 +15204,13 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex

FontCache scaling

</message>

- <message name="IDS_FLAGS_FONT_CACHE_SCALING_DESCRIPTION" desc="Description for the flag to enable FontCache scaling">

+ <message name="IDS_FLAGS_FONT_CACHE_SCALING_DESCRIPTION" desc="Description for the flag to enable Framebusting restrictions">

ojan 2016/08/30 23:36:42 I think you've got some issues in the diff here: I

+ Don't permit an iframe to navigate the top level browsing context unless they are same-origin or the iframe is processing a user gesture.

+ </message>

+ <message name="IDS_FLAGS_FRAMEBUSTING_NAME" desc="Title for the flag to enable FontCache Framebusting restrictions">

+ Framebusting requires same-origin or a user gesture

+ </message>

+ <message name="IDS_FLAGS_FRAMEBUSTING_DESCRIPTION" desc="Description for the flag to enable FontCache scaling">

Reuse a cached font in the renderer to serve different sizes of font for faster layout.

</message>