Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(143)

Issue 2092273002: Revert "Turn on clang_use_chrome_plugins for GYP as well." (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert "Turn on clang_use_chrome_plugins for GYP as well." This reverts commit f7f659c2c98a4d02e3695266d33f449b7be01af9. PDFium roll in Chromium fails on linux_chromium_chromeos_ozone_rel_ng. TBR=dsinclair@chromium.org BUG=pdfium:469 Committed: https://pdfium.googlesource.com/pdfium/+/17dfaa781ba3a72740cce157bb38e7d6bf86067e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pdfium.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Lei Zhang
TBR https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/191520 says: [33/9904] CXX obj/third_party/pdfium/core/fpdfapi/fpdf_parser/fpdfapi.cpdf_reference.o FAILED: obj/third_party/pdfium/core/fpdfapi/fpdf_parser/fpdfapi.cpdf_reference.o /b/build/slave/cache/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/pdfium/core/fpdfapi/fpdf_parser/fpdfapi.cpdf_reference.o.d -DOPJ_STATIC -DPNG_PREFIX ...
4 years, 4 months ago (2016-06-24 21:45:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2092273002/1
4 years, 4 months ago (2016-06-24 21:45:50 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-06-24 21:54:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/17dfaa781ba3a72740cce157bb38e7d6bf86...

Powered by Google App Engine
This is Rietveld 408576698