Revert "Turn on clang_use_chrome_plugins for GYP as well."

Revert "Turn on clang_use_chrome_plugins for GYP as well."

This reverts commit f7f659c2c98a4d02e3695266d33f449b7be01af9.

PDFium roll in Chromium fails on linux_chromium_chromeos_ozone_rel_ng.

TBR=dsinclair@chromium.org
BUG=pdfium:469
Committed: https://pdfium.googlesource.com/pdfium/+/17dfaa781ba3a72740cce157bb38e7d6bf86067e

[Lei Zhang, 2016-06-24 21:44:31]

Description was changed from

==========
Revert "Turn on clang_use_chrome_plugins for GYP as well."

This reverts commit f7f659c2c98a4d02e3695266d33f449b7be01af9.

PDFium roll in Chromium fails on linux_chromium_chromeos_ozone_rel_ng.

BUG=pdfium:469
==========

to

==========
Revert "Turn on clang_use_chrome_plugins for GYP as well."

This reverts commit f7f659c2c98a4d02e3695266d33f449b7be01af9.

PDFium roll in Chromium fails on linux_chromium_chromeos_ozone_rel_ng.

TBR=dsinclair@chromium.org
BUG=pdfium:469
==========

[Lei Zhang, 2016-06-24 21:44:31]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Lei Zhang, 2016-06-24 21:45:18]

TBR

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
says:

[33/9904] CXX
obj/third_party/pdfium/core/fpdfapi/fpdf_parser/fpdfapi.cpdf_reference.o
FAILED: obj/third_party/pdfium/core/fpdfapi/fpdf_parser/fpdfapi.cpdf_reference.o

/b/build/slave/cache/cipd/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/third_party/pdfium/core/fpdfapi/fpdf_parser/fpdfapi.cpdf_reference.o.d
-DOPJ_STATIC -DPNG_PREFIX -DPNG_USE_READ_MACROS -DV8_DEPRECATION_WARNINGS
-D_FILE_OFFSET_BITS=64 -DPDF_ENABLE_V8 -D_FX_CPU_=_FX_X64_ -DCHROMIUM_BUILD
-DCR_CLANG_REVISION=270823-1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
-DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_OZONE=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DIMAGE_LOADER_EXTENSION=1
-DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS
-DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS -DENABLE_WAYLAND_SERVER=1 -DUSE_UDEV
-DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1
-DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_PRINTING=1
-DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
-DSAFE_BROWSING_DB_LOCAL -DUSE_LIBPCI=1 -DUSE_NSS_CERTS=1 -DOS_CHROMEOS=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -I../../third_party/pdfium
-I../../third_party/pdfium/third_party/freetype/include
-I../../third_party/pdfium/third_party/freetype/include/freetype -Igen -Werror
-pthread -fno-strict-aliasing -Wall -Wextra -Wno-unused-parameter
-Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC
-fcolor-diagnostics -Wno-reserved-user-defined-literal -Xclang -load -Xclang
/b/build/slave/linux_chromeos/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
-plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang
-plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -Xclang
-plugin-arg-find-bad-constructs -Xclang check-ipc
-B/b/build/slave/linux_chromeos/build/src/third_party/binutils/Linux_x64/Release/bin
-fPIC -Xclang -load -Xclang -Xclang -add-plugin -Xclang -Xclang
-plugin-arg-find-bad-constructs -Xclang -Xclang -plugin-arg-find-bad-constructs
-Xclang -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template -m64 -march=x86-64 -O2
-fno-ident -fdata-sections -ffunction-sections -funwind-tables -fno-exceptions
-fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11  -c
../../third_party/pdfium/core/fpdfapi/fpdf_parser/cpdf_reference.cpp -o
obj/third_party/pdfium/core/fpdfapi/fpdf_parser/fpdfapi.cpdf_reference.o
clang: error: unknown argument: '-plugin-arg-find-bad-constructs'
clang: error: unknown argument: '-plugin-arg-find-bad-constructs'

[Lei Zhang, 2016-06-24 21:45:40]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-06-24 21:45:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 21:54:53]

Description was changed from

==========
Revert "Turn on clang_use_chrome_plugins for GYP as well."

This reverts commit f7f659c2c98a4d02e3695266d33f449b7be01af9.

PDFium roll in Chromium fails on linux_chromium_chromeos_ozone_rel_ng.

TBR=dsinclair@chromium.org
BUG=pdfium:469
==========

to

==========
Revert "Turn on clang_use_chrome_plugins for GYP as well."

This reverts commit f7f659c2c98a4d02e3695266d33f449b7be01af9.

PDFium roll in Chromium fails on linux_chromium_chromeos_ozone_rel_ng.

TBR=dsinclair@chromium.org
BUG=pdfium:469

Committed:
https://pdfium.googlesource.com/pdfium/+/17dfaa781ba3a72740cce157bb38e7d6bf86...
==========

[commit-bot: I haz the power, 2016-06-24 21:54:54]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/17dfaa781ba3a72740cce157bb38e7d6bf86...