Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/browser/chromeos/arc/arc_navigation_throttle.h

Issue 2092253002: Record UMA in ArcNavigationThrottle::OnDisambigDialogClosed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/arc/arc_navigation_throttle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_navigation_throttle.h
diff --git a/chrome/browser/chromeos/arc/arc_navigation_throttle.h b/chrome/browser/chromeos/arc/arc_navigation_throttle.h
index c385b979c33bcc6ef2b87162d972d2c65e84eb97..a859c3e71046d6165dfc581b4fdba81fdd8b21e6 100644
--- a/chrome/browser/chromeos/arc/arc_navigation_throttle.h
+++ b/chrome/browser/chromeos/arc/arc_navigation_throttle.h
@@ -26,12 +26,16 @@ namespace arc {
// traffic initiated on Chrome browser, either on Chrome or an ARC's app.
class ArcNavigationThrottle : public content::NavigationThrottle {
public:
- enum class CloseReason {
- REASON_ALWAYS_PRESSED,
- REASON_JUST_ONCE_PRESSED,
- REASON_DIALOG_DEACTIVATED,
- REASON_PREFERRED_ACTIVITY_FOUND,
- REASON_ERROR
+ // These enums are used to define the buckets for an enumerated UMA histogram
+ // and need to be synced with histograms.xml. This enum class should also be
+ // treated as append-only.
+ enum class CloseReason : int {
+ ERROR = 0,
+ DIALOG_DEACTIVATED = 1,
+ ALWAYS_PRESSED = 2,
+ JUST_ONCE_PRESSED = 3,
+ PREFERRED_ACTIVITY_FOUND = 4,
+ SIZE,
};
using NameAndIcon = std::pair<std::string, gfx::Image>;
« no previous file with comments | « no previous file | chrome/browser/chromeos/arc/arc_navigation_throttle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698