Copy more helper DLLs for cdb.exe.

Copy more helper DLLs for cdb.exe.

These are required to get access to the !uniqstack command, to be able
to dump all threads' stacks from a minidump.

BUG=609252
Committed: https://crrev.com/f9319d64b21f372bddd073b46c6bd0a089dc657f
Cr-Commit-Position: refs/heads/master@{#402295}

[Ken Russell (switch to Gerrit), 2016-06-25 01:31:52]

kbr@chromium.org changed reviewers:
+ nednguyen@google.com, scottmg@chromium.org, thakis@chromium.org

[Ken Russell (switch to Gerrit), 2016-06-25 01:31:52]

nednguyen and (scottmg or thakis): please review. Thanks.

vmiura, jbauman: FYI.

Tested locally with failure injection, and a dependent Catapult change that uses
a different cdb.exe command to dump all threads' stacks.

[nednguyen, 2016-06-25 01:39:01]

https://codereview.chromium.org/2092083004/diff/1/tools/perf/chrome_telemetry...
File tools/perf/chrome_telemetry_build/BUILD.gn (right):

https://codereview.chromium.org/2092083004/diff/1/tools/perf/chrome_telemetry...
tools/perf/chrome_telemetry_build/BUILD.gn:17: "$root_out_dir/cdb/dbgmodel.dll",
Why not just copy everything in cdb/ ?

[scottmg, 2016-06-25 02:00:20]

https://codereview.chromium.org/2092083004/diff/1/build/win/copy_cdb_to_outpu...
File build/win/copy_cdb_to_output.py (right):

https://codereview.chromium.org/2092083004/diff/1/build/win/copy_cdb_to_outpu...
build/win/copy_cdb_to_output.py:78: src_winxp_dir = os.path.join(src_dir,
'winxp')
We shouldn't need winxp\ ?

[Ken Russell (switch to Gerrit), 2016-06-27 18:46:36]

https://codereview.chromium.org/2092083004/diff/1/build/win/copy_cdb_to_outpu...
File build/win/copy_cdb_to_output.py (right):

https://codereview.chromium.org/2092083004/diff/1/build/win/copy_cdb_to_outpu...
build/win/copy_cdb_to_output.py:78: src_winxp_dir = os.path.join(src_dir,
'winxp')
On 2016/06/25 02:00:20, scottmg wrote:
> We shouldn't need winxp\ ?

That directory contains two of the CDB plugin DLLs required for the !uniqstack
command.

https://codereview.chromium.org/2092083004/diff/1/tools/perf/chrome_telemetry...
File tools/perf/chrome_telemetry_build/BUILD.gn (right):

https://codereview.chromium.org/2092083004/diff/1/tools/perf/chrome_telemetry...
tools/perf/chrome_telemetry_build/BUILD.gn:17: "$root_out_dir/cdb/dbgmodel.dll",
On 2016/06/25 01:39:01, nednguyen wrote:
> Why not just copy everything in cdb/ ?

I don't know how to express that sort of wildcard dependency in GYP and GN. If
it's possible I'll be happy to change this.

[scottmg, 2016-06-27 18:52:04]

lgtm

On 2016/06/27 18:46:36, Ken Russell wrote:
>
https://codereview.chromium.org/2092083004/diff/1/build/win/copy_cdb_to_outpu...
> File build/win/copy_cdb_to_output.py (right):
> 
>
https://codereview.chromium.org/2092083004/diff/1/build/win/copy_cdb_to_outpu...
> build/win/copy_cdb_to_output.py:78: src_winxp_dir = os.path.join(src_dir,
> 'winxp')
> On 2016/06/25 02:00:20, scottmg wrote:
> > We shouldn't need winxp\ ?
> 
> That directory contains two of the CDB plugin DLLs required for the !uniqstack
> command.

Why wouldn't it? :) (Sorry was away from Windows box at the time and couldn't
check)

> 
>
https://codereview.chromium.org/2092083004/diff/1/tools/perf/chrome_telemetry...
> File tools/perf/chrome_telemetry_build/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2092083004/diff/1/tools/perf/chrome_telemetry...
> tools/perf/chrome_telemetry_build/BUILD.gn:17:
"$root_out_dir/cdb/dbgmodel.dll",
> On 2016/06/25 01:39:01, nednguyen wrote:
> > Why not just copy everything in cdb/ ?
> 
> I don't know how to express that sort of wildcard dependency in GYP and GN. If
> it's possible I'll be happy to change this.

`gn help depfile` can do that, but I probably wouldn't bother here (at least
until you don't also have to do it in gyp).

[Ken Russell (switch to Gerrit), 2016-06-27 18:54:33]

On 2016/06/27 18:52:04, scottmg wrote:
> 
> On 2016/06/27 18:46:36, Ken Russell wrote:
> >
> > I don't know how to express that sort of wildcard dependency in GYP and GN.
If
> > it's possible I'll be happy to change this.
> 
> `gn help depfile` can do that, but I probably wouldn't bother here (at least
> until you don't also have to do it in gyp).

Yes, I'd rather keep this simple and copy exactly the DLLs known to be needed.

Ned, tools/perf OWNERS review please?

[nednguyen, 2016-06-27 19:21:32]

lgtm

[Ken Russell (switch to Gerrit), 2016-06-27 20:18:40]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-06-27 20:19:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 21:39:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-27 21:40:46]

Description was changed from

==========
Copy more helper DLLs for cdb.exe.

These are required to get access to the !uniqstack command, to be able
to dump all threads' stacks from a minidump.

BUG=609252
==========

to

==========
Copy more helper DLLs for cdb.exe.

These are required to get access to the !uniqstack command, to be able
to dump all threads' stacks from a minidump.

BUG=609252

Committed: https://crrev.com/f9319d64b21f372bddd073b46c6bd0a089dc657f
Cr-Commit-Position: refs/heads/master@{#402295}
==========

[commit-bot: I haz the power, 2016-06-27 21:40:47]

Patchset 1 (id:??) landed as
https://crrev.com/f9319d64b21f372bddd073b46c6bd0a089dc657f
Cr-Commit-Position: refs/heads/master@{#402295}