Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2092073003: Don't sync homepage pref to mobile platforms. (Closed)

Created:
4 years, 6 months ago by melandory
Modified:
4 years, 5 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't sync homepage pref to mobile platforms. Chrome will start sync prefs on mobile. For homepage it is not desired. BUG=622620 Committed: https://crrev.com/533065686d0cb35523939ae71d45173aa208a558 Cr-Commit-Position: refs/heads/master@{#402190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/profiles/profile_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
melandory
PTAL.
4 years, 6 months ago (2016-06-25 00:37:43 UTC) #2
anthonyvd
lgtm
4 years, 5 months ago (2016-06-27 14:31:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2092073003/1
4 years, 5 months ago (2016-06-27 14:57:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 15:52:52 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 15:55:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/533065686d0cb35523939ae71d45173aa208a558
Cr-Commit-Position: refs/heads/master@{#402190}

Powered by Google App Engine
This is Rietveld 408576698