Make SpellChecker::respondToChangedSelection() to update layout tree explicitly

Make SpellChecker::respondToChangedSelection() to update layout tree explicitly

This patch makes |SpellChecker::respondToChangedSelection()| to update layout
tree explicitly for preparation of getting rid of grammar checking related code.

A test expectation of fast/repaint/inline-outline-repaint.html is updated, since
this patch reduced number of update test tree in |respondToChangedSelection()|
by calling |inShadowIncludingDocument()| before |isContentEditable()|, which
updates layout tree.

This patch is also a preparation of crrev.com/2089993003, Get rid of
|EUpdateStyle| parameter from |isEditablePosition()|.

BUG=619452, 623005
TEST=n/a; no user visible changes

Committed: https://crrev.com/00e7954de686c4f376c5eae0cdf367f842f263b0
Cr-Commit-Position: refs/heads/master@{#402115}

[yosin_UTC9, 2016-06-24 07:05:28]

Description was changed from

==========
2016-06-24T15:54:37

BUG=
==========

to

==========
Make SpellChecker::respondToChangedSelection() to update layout tree explicitly

This patch makes |SpellChecker::respondToChangedSelection()| to update layout
tree explicitly for preparation of getting rid of grammar checking related code.

A test expectation of fast/repaint/inline-outline-repaint.html is updated, since
this patch reduced number of update test tree in |respondToChangedSelection()|
by calling |inShadowIncludingDocument()| before |isContentEditable()|, which
updates layout tree.

BUG=619452
TEST=n/a; no user visible changes
==========

[yosin_UTC9, 2016-06-24 07:49:09]

Description was changed from

==========
Make SpellChecker::respondToChangedSelection() to update layout tree explicitly

This patch makes |SpellChecker::respondToChangedSelection()| to update layout
tree explicitly for preparation of getting rid of grammar checking related code.

A test expectation of fast/repaint/inline-outline-repaint.html is updated, since
this patch reduced number of update test tree in |respondToChangedSelection()|
by calling |inShadowIncludingDocument()| before |isContentEditable()|, which
updates layout tree.

BUG=619452
TEST=n/a; no user visible changes
==========

to

==========
Make SpellChecker::respondToChangedSelection() to update layout tree explicitly

This patch makes |SpellChecker::respondToChangedSelection()| to update layout
tree explicitly for preparation of getting rid of grammar checking related code.

A test expectation of fast/repaint/inline-outline-repaint.html is updated, since
this patch reduced number of update test tree in |respondToChangedSelection()|
by calling |inShadowIncludingDocument()| before |isContentEditable()|, which
updates layout tree.

This patch is also a preparation of crrev.com/ 2089993003, Get rid of
EUpdateStyle parameter from isEditablePosition().

BUG=619452
TEST=n/a; no user visible changes
==========

[yosin_UTC9, 2016-06-24 07:49:50]

yosin@chromium.org changed reviewers:
+ yoichio@chromium.org

[yosin_UTC9, 2016-06-24 07:49:50]

PTAL

win_chromim_rel_ng and win_clag failures aren't related to this patch.

[yosin_UTC9, 2016-06-24 08:47:46]

Description was changed from

==========
Make SpellChecker::respondToChangedSelection() to update layout tree explicitly

This patch makes |SpellChecker::respondToChangedSelection()| to update layout
tree explicitly for preparation of getting rid of grammar checking related code.

A test expectation of fast/repaint/inline-outline-repaint.html is updated, since
this patch reduced number of update test tree in |respondToChangedSelection()|
by calling |inShadowIncludingDocument()| before |isContentEditable()|, which
updates layout tree.

This patch is also a preparation of crrev.com/ 2089993003, Get rid of
EUpdateStyle parameter from isEditablePosition().

BUG=619452
TEST=n/a; no user visible changes
==========

to

==========
Make SpellChecker::respondToChangedSelection() to update layout tree explicitly

This patch makes |SpellChecker::respondToChangedSelection()| to update layout
tree explicitly for preparation of getting rid of grammar checking related code.

A test expectation of fast/repaint/inline-outline-repaint.html is updated, since
this patch reduced number of update test tree in |respondToChangedSelection()|
by calling |inShadowIncludingDocument()| before |isContentEditable()|, which
updates layout tree.

This patch is also a preparation of crrev.com/ 2089993003, Get rid of
|EUpdateStyle| parameter from |isEditablePosition()|.

BUG=619452
TEST=n/a; no user visible changes
==========

[yosin_UTC9, 2016-06-24 08:48:09]

Description was changed from

==========
Make SpellChecker::respondToChangedSelection() to update layout tree explicitly

This patch makes |SpellChecker::respondToChangedSelection()| to update layout
tree explicitly for preparation of getting rid of grammar checking related code.

A test expectation of fast/repaint/inline-outline-repaint.html is updated, since
this patch reduced number of update test tree in |respondToChangedSelection()|
by calling |inShadowIncludingDocument()| before |isContentEditable()|, which
updates layout tree.

This patch is also a preparation of crrev.com/ 2089993003, Get rid of
|EUpdateStyle| parameter from |isEditablePosition()|.

BUG=619452
TEST=n/a; no user visible changes
==========

to

==========
Make SpellChecker::respondToChangedSelection() to update layout tree explicitly

This patch makes |SpellChecker::respondToChangedSelection()| to update layout
tree explicitly for preparation of getting rid of grammar checking related code.

A test expectation of fast/repaint/inline-outline-repaint.html is updated, since
this patch reduced number of update test tree in |respondToChangedSelection()|
by calling |inShadowIncludingDocument()| before |isContentEditable()|, which
updates layout tree.

This patch is also a preparation of crrev.com/2089993003, Get rid of
|EUpdateStyle| parameter from |isEditablePosition()|.

BUG=619452, 623005
TEST=n/a; no user visible changes
==========

[yoichio, 2016-06-24 09:52:39]

https://codereview.chromium.org/2092063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2092063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:800: if
(isContinuousSpellCheckingEnabled && closeTyping) {
Why do you introduce the |closeTyping| condition?

[yosin_UTC9, 2016-06-27 01:46:49]

https://codereview.chromium.org/2092063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2092063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:800: if
(isContinuousSpellCheckingEnabled && closeTyping) {
On 2016/06/24 at 09:52:39, yoichio wrote:
> Why do you introduce the |closeTyping| condition?

This if-statement does nothing if |!closeTyping| except for calculating
|newAdjacentWords|.
When |closeType| is true and another condition, e.g.
|shouldCheckOldSelection(oldSelection)| is true, it calls
|spellCheckOldSelection()| at L821.

[yoichio, 2016-06-27 02:10:40]

https://codereview.chromium.org/2092063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2092063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:800: if
(isContinuousSpellCheckingEnabled && closeTyping) {
On 2016/06/27 01:46:49, Yosi_UTC9 wrote:
> On 2016/06/24 at 09:52:39, yoichio wrote:
> > Why do you introduce the |closeTyping| condition?
> 
> This if-statement does nothing if |!closeTyping| except for calculating
> |newAdjacentWords|.
> When |closeType| is true and another condition, e.g.
> |shouldCheckOldSelection(oldSelection)| is true, it calls
> |spellCheckOldSelection()| at L821.

I see. then we can move the |shouldCheckOldSelection(oldSelection)| condition
 to this line.

[yosin_UTC9, 2016-06-27 04:11:07]

PTAL

https://codereview.chromium.org/2092063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2092063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:800: if
(isContinuousSpellCheckingEnabled && closeTyping) {
On 2016/06/27 at 02:10:40, yoichio wrote:
> On 2016/06/27 01:46:49, Yosi_UTC9 wrote:
> > On 2016/06/24 at 09:52:39, yoichio wrote:
> > > Why do you introduce the |closeTyping| condition?
> > 
> > This if-statement does nothing if |!closeTyping| except for calculating
> > |newAdjacentWords|.
> > When |closeType| is true and another condition, e.g.
> > |shouldCheckOldSelection(oldSelection)| is true, it calls
> > |spellCheckOldSelection()| at L821.
> 
> I see. then we can move the |shouldCheckOldSelection(oldSelection)| condition
>  to this line.

You're right. Good catch!
I moved it.

[yoichio, 2016-06-27 04:14:25]

lgtm

[yosin_UTC9, 2016-06-27 04:56:12]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-06-27 04:56:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 05:02:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-27 05:05:21]

Description was changed from

==========
Make SpellChecker::respondToChangedSelection() to update layout tree explicitly

This patch makes |SpellChecker::respondToChangedSelection()| to update layout
tree explicitly for preparation of getting rid of grammar checking related code.

A test expectation of fast/repaint/inline-outline-repaint.html is updated, since
this patch reduced number of update test tree in |respondToChangedSelection()|
by calling |inShadowIncludingDocument()| before |isContentEditable()|, which
updates layout tree.

This patch is also a preparation of crrev.com/2089993003, Get rid of
|EUpdateStyle| parameter from |isEditablePosition()|.

BUG=619452, 623005
TEST=n/a; no user visible changes
==========

to

==========
Make SpellChecker::respondToChangedSelection() to update layout tree explicitly

This patch makes |SpellChecker::respondToChangedSelection()| to update layout
tree explicitly for preparation of getting rid of grammar checking related code.

A test expectation of fast/repaint/inline-outline-repaint.html is updated, since
this patch reduced number of update test tree in |respondToChangedSelection()|
by calling |inShadowIncludingDocument()| before |isContentEditable()|, which
updates layout tree.

This patch is also a preparation of crrev.com/2089993003, Get rid of
|EUpdateStyle| parameter from |isEditablePosition()|.

BUG=619452, 623005
TEST=n/a; no user visible changes

Committed: https://crrev.com/00e7954de686c4f376c5eae0cdf367f842f263b0
Cr-Commit-Position: refs/heads/master@{#402115}
==========

[commit-bot: I haz the power, 2016-06-27 05:05:22]

Patchset 2 (id:??) landed as
https://crrev.com/00e7954de686c4f376c5eae0cdf367f842f263b0
Cr-Commit-Position: refs/heads/master@{#402115}