PDF: Fix layout issues caused by removing iron-flex-layout

PDF: Fix layout issues caused by removing iron-flex-layout

In crrev.com/401161, the deprecated version of iron-flex-layout was removed
from the PDF viewer. This version added styles to the page which were seen
by every element, regardless of whether they expected it. Thus, removing
it from the page had some unexpected side effects:

* The bookmarks menu in the toolbar would always show, due to a change
  in how [hidden] was defined.
* The password field was laid out incorrectly due to not importing the
  new version of iron-flex-layout correctly.

This CL fixes both of these regressions.

BUG=622582, 621736
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/930c85305671e9a24a3ac4eb9ea1de0cd447f961
Cr-Commit-Position: refs/heads/master@{#402112}

[tsergeant, 2016-06-24 04:22:31]

Description was changed from

==========
PDF: Fix layout issues caused by removing iron-flex-layout

In crrev.com/401161, the deprecated version of iron-flex-layout was removed
from the PDF viewer. This version added styles to the page which were seen
by every element, regardless of whether they expected it. Thus, removing
it from the page had some unexpected side effects:

* The bookmarks menu in the toolbar would always show, due to a change
  in how [hidden] was defined.
* The password field was laid out incorrectly due to not importing the
  new version of iron-flex-layout correctly.

This CL fixes both of these regressions.

BUG=622582,621736
==========

to

==========
PDF: Fix layout issues caused by removing iron-flex-layout

In crrev.com/401161, the deprecated version of iron-flex-layout was removed
from the PDF viewer. This version added styles to the page which were seen
by every element, regardless of whether they expected it. Thus, removing
it from the page had some unexpected side effects:

* The bookmarks menu in the toolbar would always show, due to a change
  in how [hidden] was defined.
* The password field was laid out incorrectly due to not importing the
  new version of iron-flex-layout correctly.

This CL fixes both of these regressions.

BUG=622582,621736
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-06-24 04:31:37]

tsergeant@chromium.org changed reviewers:
+ raymes@chromium.org

[tsergeant, 2016-06-24 04:31:38]

Raymes, PTAL.

https://codereview.chromium.org/2092023002/diff/1/chrome/browser/resources/pd...
File
chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
(left):

https://codereview.chromium.org/2092023002/diff/1/chrome/browser/resources/pd...
chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html:20:
<paper-input-error hidden$="[[!invalid]]"
This hidden seems to be unnecessary -- the paper-input-container manages showing
and hiding the error.

[raymes, 2016-06-27 01:36:03]

https://codereview.chromium.org/2092023002/diff/1/chrome/browser/resources/pd...
File
chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
(right):

https://codereview.chromium.org/2092023002/diff/1/chrome/browser/resources/pd...
chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html:11:
<style include="iron-flex iron-flex-alignment"></style>
More magic! I wouldn't know if this is the right way to do things. Maybe Chris
could take a look since he's been doing more polymer lately?

https://codereview.chromium.org/2092023002/diff/1/chrome/browser/resources/pd...
File
chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.css
(left):

https://codereview.chromium.org/2092023002/diff/1/chrome/browser/resources/pd...
chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.css:6:
display: inline-block;
This isn't needed now? (Or was it just never needed?)

[tsergeant, 2016-06-27 01:47:08]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2016-06-27 01:47:08]

https://codereview.chromium.org/2092023002/diff/1/chrome/browser/resources/pd...
File
chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
(right):

https://codereview.chromium.org/2092023002/diff/1/chrome/browser/resources/pd...
chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html:11:
<style include="iron-flex iron-flex-alignment"></style>
On 2016/06/27 01:36:03, raymes wrote:
> More magic! I wouldn't know if this is the right way to do things. Maybe Chris
> could take a look since he's been doing more polymer lately?

Adding Chris for Polymer knowledge.

https://codereview.chromium.org/2092023002/diff/1/chrome/browser/resources/pd...
File
chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.css
(left):

https://codereview.chromium.org/2092023002/diff/1/chrome/browser/resources/pd...
chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.css:6:
display: inline-block;
On 2016/06/27 01:36:03, raymes wrote:
> This isn't needed now? (Or was it just never needed?)

It's not needed now, I'm...not sure if it was actually needed in the first
place.

[calamity, 2016-06-27 03:32:22]

lgtm.

Does viewer-pdf-toolbar.html also require the style modules to be imported?

[raymes, 2016-06-27 03:44:22]

On 2016/06/27 03:32:22, calamity wrote:
> lgtm.
> 
> Does viewer-pdf-toolbar.html also require the style modules to be imported?

lgtm

[tsergeant, 2016-06-27 03:51:26]

On 2016/06/27 03:32:22, calamity wrote:
> lgtm.
> 
> Does viewer-pdf-toolbar.html also require the style modules to be imported?

viewer-pdf-toolbar.html only uses the @apply mixins, which don't need to be
explicitly imported.

[tsergeant, 2016-06-27 03:51:31]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-06-27 03:51:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 04:57:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-27 05:00:39]

Description was changed from

==========
PDF: Fix layout issues caused by removing iron-flex-layout

In crrev.com/401161, the deprecated version of iron-flex-layout was removed
from the PDF viewer. This version added styles to the page which were seen
by every element, regardless of whether they expected it. Thus, removing
it from the page had some unexpected side effects:

* The bookmarks menu in the toolbar would always show, due to a change
  in how [hidden] was defined.
* The password field was laid out incorrectly due to not importing the
  new version of iron-flex-layout correctly.

This CL fixes both of these regressions.

BUG=622582,621736
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF: Fix layout issues caused by removing iron-flex-layout

In crrev.com/401161, the deprecated version of iron-flex-layout was removed
from the PDF viewer. This version added styles to the page which were seen
by every element, regardless of whether they expected it. Thus, removing
it from the page had some unexpected side effects:

* The bookmarks menu in the toolbar would always show, due to a change
  in how [hidden] was defined.
* The password field was laid out incorrectly due to not importing the
  new version of iron-flex-layout correctly.

This CL fixes both of these regressions.

BUG=622582,621736
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/930c85305671e9a24a3ac4eb9ea1de0cd447f961
Cr-Commit-Position: refs/heads/master@{#402112}
==========

[commit-bot: I haz the power, 2016-06-27 05:00:40]

Patchset 1 (id:??) landed as
https://crrev.com/930c85305671e9a24a3ac4eb9ea1de0cd447f961
Cr-Commit-Position: refs/heads/master@{#402112}