Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Issue 2091973003: Convert video-seek* tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-seek* tests to testharness.js Cleaning up video-seek* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/05efff15aea8ddbd650db77da38067227e96c892 Cr-Commit-Position: refs/heads/master@{#402063}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -208 lines) Patch
M third_party/WebKit/LayoutTests/media/video-seek-by-small-increment.html View 1 chunk +33 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-seek-by-small-increment-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-seek-no-src.html View 1 chunk +14 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-seek-no-src-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-seek-past-end-paused.html View 1 chunk +41 lines, -71 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-seek-past-end-paused-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-24 09:26:33 UTC) #4
fs
lgtm
4 years, 6 months ago (2016-06-24 15:32:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091973003/20001
4 years, 6 months ago (2016-06-25 13:37:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-25 14:53:42 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-25 14:55:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05efff15aea8ddbd650db77da38067227e96c892
Cr-Commit-Position: refs/heads/master@{#402063}

Powered by Google App Engine
This is Rietveld 408576698