mash: Move TrayTracing to //ash/common/system/chromeos

mash: Move TrayTracing to //ash/common/system/chromeos

* Convert to WmShell and WmSystemTrayNotifier
* Wrap the WmSystemTrayNotifier bits in OS_CHROMEOS guards because this
  feature only exists on Chrome OS.

BUG=619636
TEST=manual, go to chrome://slow and turn it on and off, see status area icon

Committed: https://crrev.com/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2
Cr-Commit-Position: refs/heads/master@{#401893}

[James Cook, 2016-06-23 22:36:24]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-06-23 22:36:24]

msw, please take a look

[msw, 2016-06-24 02:07:11]

lgtm with nits

https://codereview.chromium.org/2091953002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/tray_tracing.cc (right):

https://codereview.chromium.org/2091953002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/tray_tracing.cc:13: #include
"ash/system/tray/system_tray.h"
nit: could we instead forward declare SystemTray here?

https://codereview.chromium.org/2091953002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/tray_tracing.h (right):

https://codereview.chromium.org/2091953002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/tray_tracing.h:23: virtual void
OnTracingModeChanged(bool value) = 0;
nit: bonus points for clarifying silly bool param "value" or the comment.

[James Cook, 2016-06-24 16:28:17]

jamescook@chromium.org changed reviewers:
+ stevenjb@chromium.org

[James Cook, 2016-06-24 16:28:18]

stevenjb, can I get OWNERS for the trivial change to c/b/ui/ash ?

https://codereview.chromium.org/2091953002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/tray_tracing.cc (right):

https://codereview.chromium.org/2091953002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/tray_tracing.cc:13: #include
"ash/system/tray/system_tray.h"
On 2016/06/24 02:07:11, msw wrote:
> nit: could we instead forward declare SystemTray here?

Done.

https://codereview.chromium.org/2091953002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/tray_tracing.h (right):

https://codereview.chromium.org/2091953002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/tray_tracing.h:23: virtual void
OnTracingModeChanged(bool value) = 0;
On 2016/06/24 02:07:11, msw wrote:
> nit: bonus points for clarifying silly bool param "value" or the comment.

"Notified when |value| gets a new value which is valuable." j/k. Changed to
"enabled" here and elsewhere and clarified comment.

[stevenjb, 2016-06-24 16:34:31]

RS LGTM

[James Cook, 2016-06-24 16:43:22]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-24 16:43:22]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2091953002/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2016-06-24 16:44:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 17:36:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-24 17:37:54]

Description was changed from

==========
mash: Move TrayTracing to //ash/common/system/chromeos

* Convert to WmShell and WmSystemTrayNotifier
* Wrap the WmSystemTrayNotifier bits in OS_CHROMEOS guards because this
  feature only exists on Chrome OS.

BUG=619636
TEST=manual, go to chrome://slow and turn it on and off, see status area icon
==========

to

==========
mash: Move TrayTracing to //ash/common/system/chromeos

* Convert to WmShell and WmSystemTrayNotifier
* Wrap the WmSystemTrayNotifier bits in OS_CHROMEOS guards because this
  feature only exists on Chrome OS.

BUG=619636
TEST=manual, go to chrome://slow and turn it on and off, see status area icon

Committed: https://crrev.com/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2
Cr-Commit-Position: refs/heads/master@{#401893}
==========

[commit-bot: I haz the power, 2016-06-24 17:37:56]

Patchset 3 (id:??) landed as
https://crrev.com/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2
Cr-Commit-Position: refs/heads/master@{#401893}