chrome/renderer/spellchecker/cocoa_spelling_engine_mac.cc - Issue 209193002: Remove PlatformFile from spell checker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/spellchecker/cocoa_spelling_engine_mac.cc

Issue 209193002: Remove PlatformFile from spell checker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revert IsEnabled behavior Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/spellchecker/cocoa_spelling_engine_mac.cc

diff --git a/chrome/renderer/spellchecker/cocoa_spelling_engine_mac.cc b/chrome/renderer/spellchecker/cocoa_spelling_engine_mac.cc

index ca14fab220e8f52b1f1a7cfc27b2165e98be2e00..b71e652ebe29d63a1db835eb036942a9ba102347 100644

--- a/chrome/renderer/spellchecker/cocoa_spelling_engine_mac.cc

+++ b/chrome/renderer/spellchecker/cocoa_spelling_engine_mac.cc

@@ -13,8 +13,8 @@ SpellingEngine* CreateNativeSpellingEngine() {

return new CocoaSpellingEngine();

}

-void CocoaSpellingEngine::Init(base::PlatformFile bdict_file) {

- DCHECK(bdict_file == base::kInvalidPlatformFileValue);

+void CocoaSpellingEngine::Init(base::File bdict_file) {

+ DCHECK(!bdict_file.IsValid());

}

bool CocoaSpellingEngine::InitializeIfNeeded() {