Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 2091923003: Fix incorrect swizzle on BGRA platforms in filterColor4f path (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
herb_g, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix incorrect swizzle on BGRA platforms in filterColor4f path BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2091923003 Committed: https://skia.googlesource.com/skia/+/e2cddc5342d5aacacce4429441c94d1e0ff67d8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/core/SkColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPM4f.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091923003/1
4 years, 6 months ago (2016-06-24 18:12:44 UTC) #3
Brian Osman
Changes the results of three GMs in raster-srgb mode (they were previously incorrect, now they're ...
4 years, 6 months ago (2016-06-24 18:13:37 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 18:28:35 UTC) #7
reed1
lgtm
4 years, 6 months ago (2016-06-24 18:50:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091923003/1
4 years, 6 months ago (2016-06-24 18:54:18 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 18:55:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e2cddc5342d5aacacce4429441c94d1e0ff67d8c

Powered by Google App Engine
This is Rietveld 408576698