Add Histogram for currentURLWithTrustLevel removal.

Add Histogram for currentURLWithTrustLevel removal.

With WKWebView, there is no longer a trust level associated with the
current URL. This histogram will be used to validate that the WebState's
|lastCommittedURL| is equal to the WebController's
|currentURLWithTrustLevel:| before we remove the latter.

BUG=none

Committed: https://crrev.com/15d120491ed3e236e1191243db6fa2ce8284e2ca
Cr-Commit-Position: refs/heads/master@{#402655}

[michaeldo, 2016-06-23 22:09:54]

michaeldo@chromium.org changed reviewers:
+ mpearson@chromium.org

[Mark P, 2016-06-24 03:39:00]

https://codereview.chromium.org/2091913002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2091913002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:60884: +<histogram
name="Web.CurrentURLEqualsLastCommittedURL">
units=?

https://codereview.chromium.org/2091913002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:60890: +    GetLastCommittedURL.
Please try to briefly describe when this is emitted.

[michaeldo, 2016-06-24 05:24:56]

Updated. PTAL.

https://codereview.chromium.org/2091913002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2091913002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:60884: +<histogram
name="Web.CurrentURLEqualsLastCommittedURL">
On 2016/06/24 03:39:00, Mark P wrote:
> units=?

Sorry, I didn't realize we had specialized boolean units. Updated with specific
BooleanEqual enum.

https://codereview.chromium.org/2091913002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:60890: +    GetLastCommittedURL.
On 2016/06/24 03:39:00, Mark P wrote:
> Please try to briefly describe when this is emitted.

Done.

[Mark P, 2016-06-24 17:20:43]

generally lgtm with another comment remaining

--mark

https://codereview.chromium.org/2091913002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2091913002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:60891: +   
GetCurrentURL(URLVerificationTrustLevel* trust_level) is called.
nit: briefly describe what causes this function to be called.

[michaeldo, 2016-06-28 22:40:47]

The CQ bit was checked by michaeldo@chromium.org

[michaeldo, 2016-06-28 22:40:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/2091913002/#ps40001
(title: "Add more detail to historgram description.")

[commit-bot: I haz the power, 2016-06-28 22:42:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 02:11:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-29 02:13:33]

Description was changed from

==========
Add Histogram for currentURLWithTrustLevel removal.

With WKWebView, there is no longer a trust level associated with the
current URL. This histogram will be used to validate that the WebState's
|lastCommittedURL| is equal to the WebController's
|currentURLWithTrustLevel:| before we remove the latter.

BUG=none
==========

to

==========
Add Histogram for currentURLWithTrustLevel removal.

With WKWebView, there is no longer a trust level associated with the
current URL. This histogram will be used to validate that the WebState's
|lastCommittedURL| is equal to the WebController's
|currentURLWithTrustLevel:| before we remove the latter.

BUG=none

Committed: https://crrev.com/15d120491ed3e236e1191243db6fa2ce8284e2ca
Cr-Commit-Position: refs/heads/master@{#402655}
==========

[commit-bot: I haz the power, 2016-06-29 02:13:38]

Patchset 3 (id:??) landed as
https://crrev.com/15d120491ed3e236e1191243db6fa2ce8284e2ca
Cr-Commit-Position: refs/heads/master@{#402655}