Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: media/base/pipeline_impl_unittest.cc

Issue 2091893003: Make PipelineImpl state change tasks consistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/base/pipeline_impl.cc ('K') | « media/base/pipeline_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_impl_unittest.cc
diff --git a/media/base/pipeline_impl_unittest.cc b/media/base/pipeline_impl_unittest.cc
index 6333e8dcd274622521afea8abdcfad613e3b9304..661830c673f92fb08b77d640445f569d9c9bdc90 100644
--- a/media/base/pipeline_impl_unittest.cc
+++ b/media/base/pipeline_impl_unittest.cc
@@ -898,15 +898,14 @@ class PipelineTeardownTest : public PipelineImplTest {
EXPECT_CALL(*renderer_, Initialize(_, _, _))
.WillOnce(
DoAll(Stop(pipeline_.get()), PostCallback<2>(PIPELINE_OK)));
- // Note: OnStart or OnMetadata callback are not called
- // after pipeline is stopped.
+ // Note: OnStart is not callback after pipeline is stopped.
} else {
EXPECT_CALL(*renderer_, Initialize(_, _, _))
.WillOnce(PostCallback<2>(PIPELINE_ERROR_INITIALIZATION_FAILED));
- EXPECT_CALL(callbacks_, OnMetadata(_));
EXPECT_CALL(callbacks_, OnStart(PIPELINE_ERROR_INITIALIZATION_FAILED));
}
+ EXPECT_CALL(callbacks_, OnMetadata(_));
EXPECT_CALL(*demuxer_, Stop());
return;
}
« media/base/pipeline_impl.cc ('K') | « media/base/pipeline_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698