Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: media/base/pipeline_impl.h

Issue 2091893003: Make PipelineImpl state change tasks consistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/pipeline_impl.cc » ('j') | media/base/pipeline_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_impl.h
diff --git a/media/base/pipeline_impl.h b/media/base/pipeline_impl.h
index 45b4454c5ce1e220652a6696ad802f3a4924e4b9..ccc39650d7327b4c083b101de63c36839c348a51 100644
--- a/media/base/pipeline_impl.h
+++ b/media/base/pipeline_impl.h
@@ -32,7 +32,7 @@ class TextRenderer;
// [ *Created ] [ Any State ]
// | Start() | Stop() / SetError()
// V V
-// [ InitXXX (for each filter) ] [ Stopping ]
+// [ Starting ] [ Stopping ]
// | |
// V V
// [ Playing ] <---------. [ Stopped ]
@@ -105,8 +105,7 @@ class MEDIA_EXPORT PipelineImpl : public Pipeline {
// from MediaLog.
enum State {
kCreated,
- kInitDemuxer,
- kInitRenderer,
+ kStarting,
kSeeking,
kPlaying,
kStopping,
@@ -130,8 +129,8 @@ class MEDIA_EXPORT PipelineImpl : public Pipeline {
void OnVideoOpacityChange(bool opaque);
// Task completion callbacks from RendererWrapper.
- void OnSeekDone(base::TimeDelta start_time);
- void OnSuspendDone(base::TimeDelta suspend_time);
+ void OnSeekDone();
+ void OnSuspendDone();
// Parameters passed in the constructor.
const scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_;
« no previous file with comments | « no previous file | media/base/pipeline_impl.cc » ('j') | media/base/pipeline_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698