Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 2091883002: Add '--finer-grained-invalidation' option to Analysis Server. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add '--finer-grained-invalidation' option to Analysis Server. I think we could start fishfooding it. There might still be bugs, and I saw it still invalidating more than I would like. But we can fix these problems. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3f1955a819bd4bc051bc5c4d5deb4695f57a8a7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -19 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 4 chunks +12 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 4 chunks +4 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 6 months ago (2016-06-23 18:32:18 UTC) #1
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-23 18:41:01 UTC) #2
scheglov
4 years, 6 months ago (2016-06-23 20:10:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3f1955a819bd4bc051bc5c4d5deb4695f57a8a7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698