Issue 209183003: Fix "unreachable code" warnings (MSVC warning 4702) in a PPAPI test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209183003: Fix "unreachable code" warnings (MSVC warning 4702) in a PPAPI test. (Closed)

Created:
6 years, 9 months ago by Peter Kasting

Modified:
6 years, 9 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix "unreachable code" warnings (MSVC warning 4702) in a PPAPI test. We can't convert preprocessor defines into unconditional early-returns. Instead make these functions simply do nothing when DISABLE_NACL is on. BUG=346399 TEST=none R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258971

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	chrome/test/ppapi/ppapi_test.cc	View		4 chunks	+16 lines, -16 lines	0 comments	Download

Total messages: 3 (0 generated)

Peter Kasting

6 years, 9 months ago (2014-03-24 18:12:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r258971 (presubmit successful).