QuickView: Add labels and tabindex for accessibility.

QuickView: Add labels and tabindex for accessibility.

This CL is based on https://codereview.chromium.org/2093673002/.

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler

Committed: https://crrev.com/7f91fe95ec0e89c7947ac2e65c62deaca25849b9
Cr-Commit-Position: refs/heads/master@{#402431}

[oka, 2016-06-23 15:12:16]

nit

[oka, 2016-06-23 15:12:25]

Description was changed from

==========
QuickView: Add labels and tabindex for accessibility.

BUG=613465
TEST=manually
==========

to

==========
QuickView: Add labels and tabindex for accessibility.

This CL is based on https://codereview.chromium.org/2093673002/.

BUG=613465
TEST=manually
==========

[oka, 2016-06-23 15:13:58]

Description was changed from

==========
QuickView: Add labels and tabindex for accessibility.

This CL is based on https://codereview.chromium.org/2093673002/.

BUG=613465
TEST=manually
==========

to

==========
QuickView: Add labels and tabindex for accessibility.

This CL is based on https://codereview.chromium.org/2093673002/.

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

[oka, 2016-06-23 15:15:52]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-06-23 15:15:53]

PTAL.
This CL based on the previously sent CL
https://codereview.chromium.org/2093673002/.

[fukino, 2016-06-23 22:53:34]

lgtm with nits

https://codereview.chromium.org/2091823002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.css
(right):

https://codereview.chromium.org/2091823002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:35: }
needs a blank line, or combine it with following audio::-webkit-...

https://codereview.chromium.org/2091823002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/quick_view_controller.js
(right):

https://codereview.chromium.org/2091823002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/quick_view_controller.js:74: var
elems = this.quickView_.shadowRoot.querySelectorAll('[has-tooltip]');
Does quickView_.$.buttons.querySelectorAll() work?
If it does, it should be preferable.
https://github.com/Polymer/docs/issues/477#issuecomment-47436336

[oka, 2016-06-27 11:40:10]

nit

[oka, 2016-06-27 11:41:20]

https://codereview.chromium.org/2091823002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.css
(right):

https://codereview.chromium.org/2091823002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.css:35: }
On 2016/06/23 22:53:33, fukino wrote:
> needs a blank line, or combine it with following audio::-webkit-...

Done.

https://codereview.chromium.org/2091823002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/quick_view_controller.js
(right):

https://codereview.chromium.org/2091823002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/quick_view_controller.js:74: var
elems = this.quickView_.shadowRoot.querySelectorAll('[has-tooltip]');
On 2016/06/23 22:53:34, fukino wrote:
> Does quickView_.$.buttons.querySelectorAll() work?
> If it does, it should be preferable.
> https://github.com/Polymer/docs/issues/477#issuecomment-47436336

Done.

[oka, 2016-06-28 07:58:15]

The CQ bit was checked by oka@chromium.org

[oka, 2016-06-28 07:58:15]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2091823002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-06-28 07:58:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 07:59:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 08:00:00]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[oka, 2016-06-28 08:14:53]

Rebase

[oka, 2016-06-28 08:17:00]

The CQ bit was checked by oka@chromium.org

[oka, 2016-06-28 08:17:01]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2091823002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-28 08:17:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 09:09:55]

Description was changed from

==========
QuickView: Add labels and tabindex for accessibility.

This CL is based on https://codereview.chromium.org/2093673002/.

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

to

==========
QuickView: Add labels and tabindex for accessibility.

This CL is based on https://codereview.chromium.org/2093673002/.

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

[commit-bot: I haz the power, 2016-06-28 09:09:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-28 09:12:39]

Description was changed from

==========
QuickView: Add labels and tabindex for accessibility.

This CL is based on https://codereview.chromium.org/2093673002/.

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler
==========

to

==========
QuickView: Add labels and tabindex for accessibility.

This CL is based on https://codereview.chromium.org/2093673002/.

BUG=613465
TEST=manually
third_party/closure_compiler/run_compiler

Committed: https://crrev.com/7f91fe95ec0e89c7947ac2e65c62deaca25849b9
Cr-Commit-Position: refs/heads/master@{#402431}
==========

[commit-bot: I haz the power, 2016-06-28 09:12:41]

Patchset 4 (id:??) landed as
https://crrev.com/7f91fe95ec0e89c7947ac2e65c62deaca25849b9
Cr-Commit-Position: refs/heads/master@{#402431}