src/x64/macro-assembler-x64.h - Issue 2091733002: Reland [heap] Avoid the use of cells to point from code to new-space objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.h

Issue 2091733002: Reland [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/macro-assembler-x64.h

diff --git a/src/x64/macro-assembler-x64.h b/src/x64/macro-assembler-x64.h

index b088c7d19c44a1d2301af08c19fb2f689b56df2c..887f4314f7bbb94b8f8b82ba5dab5f199caa7c56 100644

--- a/src/x64/macro-assembler-x64.h

+++ b/src/x64/macro-assembler-x64.h

@@ -927,7 +927,6 @@ class MacroAssembler: public Assembler {

AllowDeferredHandleDereference using_raw_address;

DCHECK(!RelocInfo::IsNone(rmode));

DCHECK(value->IsHeapObject());

- DCHECK(!isolate()->heap()->InNewSpace(*value));

movp(dst, reinterpret_cast<void*>(value.location()), rmode);

}

« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »