Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: src/mips/assembler-mips-inl.h

Issue 2091733002: Reland [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/assembler-mips.cc ('k') | src/mips/macro-assembler-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright (c) 1994-2006 Sun Microsystems Inc. 2 // Copyright (c) 1994-2006 Sun Microsystems Inc.
3 // All Rights Reserved. 3 // All Rights Reserved.
4 // 4 //
5 // Redistribution and use in source and binary forms, with or without 5 // Redistribution and use in source and binary forms, with or without
6 // modification, are permitted provided that the following conditions are 6 // modification, are permitted provided that the following conditions are
7 // met: 7 // met:
8 // 8 //
9 // - Redistributions of source code must retain the above copyright notice, 9 // - Redistributions of source code must retain the above copyright notice,
10 // this list of conditions and the following disclaimer. 10 // this list of conditions and the following disclaimer.
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 ICacheFlushMode icache_flush_mode) { 218 ICacheFlushMode icache_flush_mode) {
219 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); 219 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
220 Assembler::set_target_address_at(isolate_, pc_, host_, 220 Assembler::set_target_address_at(isolate_, pc_, host_,
221 reinterpret_cast<Address>(target), 221 reinterpret_cast<Address>(target),
222 icache_flush_mode); 222 icache_flush_mode);
223 if (write_barrier_mode == UPDATE_WRITE_BARRIER && 223 if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
224 host() != NULL && 224 host() != NULL &&
225 target->IsHeapObject()) { 225 target->IsHeapObject()) {
226 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode( 226 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
227 host(), this, HeapObject::cast(target)); 227 host(), this, HeapObject::cast(target));
228 host()->GetHeap()->RecordWriteIntoCode(host(), this, target);
228 } 229 }
229 } 230 }
230 231
231 232
232 Address RelocInfo::target_external_reference() { 233 Address RelocInfo::target_external_reference() {
233 DCHECK(rmode_ == EXTERNAL_REFERENCE); 234 DCHECK(rmode_ == EXTERNAL_REFERENCE);
234 return Assembler::target_address_at(pc_, host_); 235 return Assembler::target_address_at(pc_, host_);
235 } 236 }
236 237
237 238
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 CheckBuffer(); 488 CheckBuffer();
488 } 489 }
489 EmitHelper(x, is_compact_branch); 490 EmitHelper(x, is_compact_branch);
490 } 491 }
491 492
492 493
493 } // namespace internal 494 } // namespace internal
494 } // namespace v8 495 } // namespace v8
495 496
496 #endif // V8_MIPS_ASSEMBLER_MIPS_INL_H_ 497 #endif // V8_MIPS_ASSEMBLER_MIPS_INL_H_
OLDNEW
« no previous file with comments | « src/mips/assembler-mips.cc ('k') | src/mips/macro-assembler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698